Improve path presentation in quick open window#307764
Open
as567-code wants to merge 2 commits intomicrosoft:mainfrom
Open
Improve path presentation in quick open window#307764as567-code wants to merge 2 commits intomicrosoft:mainfrom
as567-code wants to merge 2 commits intomicrosoft:mainfrom
Conversation
When multiple files share the same name but reside in different directories, the quick open description (file path) now truncates from the left using RTL direction, preserving the distinguishing folder names at the end of the path. Before: some_project/some_longer_path.../Main.js After: .../fruits/bananas/Main.js Fixes microsoft#143956
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
Adds unicode-bidi: plaintext to ensure path separators render correctly with RTL direction, and adds explanatory comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143956
Description
When multiple files share the same name but reside in different directories, the Quick Open (Cmd+P) description (file path) truncates from the right, hiding the distinguishing folder names. This makes it impossible to tell files apart.
Before:
some_project/some_longer_path...(ellipsis on right, distinguishing part hidden)After:
...fruits/bananas/Main.js(ellipsis on left, distinguishing part visible)Approach
Added a CSS rule scoped to the quick input list that applies
direction: rtlwithtext-align: leftto the path description element. This causes the browser to place the text-overflow ellipsis on the left side while keeping the text visually left-aligned, similar to how Sublime Text handles this (as referenced in the issue).Changes
src/vs/platform/quickinput/browser/media/quickInput.css— added RTL direction rule for.label-descriptionwithin quick input list rowsTesting