Skip to content

Change GHE enterprise sign-in button label from "GHE.com" to "GHE"#307717

Open
Copilot wants to merge 2 commits intomainfrom
copilot/update-ghe-button-label
Open

Change GHE enterprise sign-in button label from "GHE.com" to "GHE"#307717
Copilot wants to merge 2 commits intomainfrom
copilot/update-ghe-button-label

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026

The enterprise sign-in button in the sessions/agents window onboarding was labeled "GHE.com" (via the hardcoded fallback). Changed the fallback to "GHE".

  • sessionsWalkthrough.ts: Update fallback enterpriseProviderName from 'GHE.com''GHE'
// Before
const enterpriseProviderName = this.productService.defaultChatAgent?.provider?.enterprise?.name || 'GHE.com';

// After
const enterpriseProviderName = this.productService.defaultChatAgent?.provider?.enterprise?.name || 'GHE';

The label when the product service provides an explicit enterprise.name is unchanged.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh pr create --title Change enterprise sign-in button label from 'GHE.com' to 'GHE' --body In the sessions/agents window app onboarding, the sign-in button for the enterprise provider showed "GHE.com" as the fallback label. This changes the fallback default from 'GHE.com'to'GHE' so the button now displays just "GHE" instead. --head copilot/update-ghe-button-label (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

in the sessions/agents window app onboarding, there is a sign in button labeled "GHE.COM". change it to just "GHE"

The user has attached the following file paths as relevant context:

  • .github/copilot-instructions.md
  • AGENTS.md

Created from VS Code.

@eli-w-king eli-w-king requested a review from hawkticehurst April 3, 2026 20:50
Copilot AI changed the title [WIP] Update sign in button label from 'GHE.COM' to 'GHE' Change GHE enterprise sign-in button label from "GHE.com" to "GHE" Apr 3, 2026
Copilot AI requested a review from eli-w-king April 3, 2026 20:51
@eli-w-king eli-w-king marked this pull request as ready for review April 3, 2026 20:51
Copilot AI review requested due to automatic review settings April 3, 2026 20:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Sessions/Agents welcome onboarding UI so the enterprise sign-in provider fallback label displays “GHE” instead of “GHE.com” when no enterprise provider name is supplied by productService.

Changes:

  • Change the hardcoded fallback enterpriseProviderName from 'GHE.com' to 'GHE' in the Sessions walkthrough sign-in screen.
Show a summary per file
File Description
src/vs/sessions/contrib/welcome/browser/sessionsWalkthrough.ts Adjusts the enterprise provider name fallback used for the enterprise sign-in button label/ARIA label/title.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants