Skip to content

Conversation

@TylerLeonhardt
Copy link
Member

It's redundant with 'provider registration and immediate disposal race condition' anyway.

Fixes #255118

It's redundant with 'provider registration and immediate disposal race condition' anyway.

Fixes #255118
Copilot AI review requested due to automatic review settings January 6, 2026 00:12
@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) January 6, 2026 00:12
@TylerLeonhardt TylerLeonhardt self-assigned this Jan 6, 2026
@vs-code-engineering vs-code-engineering bot added this to the December 2025 milestone Jan 6, 2026
@Tyriar
Copy link
Member

Tyriar commented Jan 6, 2026

CI

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a flakey integration test that was causing intermittent failures. The test attempted to verify session operations during provider lifecycle changes by disposing a provider while a session creation was in progress, but this timing-dependent behavior made it unreliable.

Key Changes:

  • Removed the 'session operations during provider lifecycle changes' test which relied on timing assumptions (setTimeout delays)
  • The functionality is already covered by the more deterministic 'provider registration and immediate disposal race condition' test

@TylerLeonhardt TylerLeonhardt merged commit 1b4715b into main Jan 6, 2026
36 of 39 checks passed
@TylerLeonhardt TylerLeonhardt deleted the tyler/intense-porcupine branch January 6, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky ExtHostAuthentication test

3 participants