Fix/ai search copy all #284498 #285112
Open
Fix/ai search copy all #284498 #285112
+34
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #284498 where the "Copy All" command in the search view wasn't distinguishing between normal search results and AI search results. The fix ensures that when copying all results, the command respects the context (AI or regular search) of the clicked element.
Key Changes:
- Modified
copyAllCommandto accept amatchparameter to determine the search context - Added
isAISearchResulthelper function to identify if an element belongs to AI search results - Updated
CopyAllCommandAction.run()to pass the match parameter through to the command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #284498
The issue was caused by the fact that the copyAllCommand wasn't considering whether the click was done on normal searches or ai searches.
Test it:
Go to search -> AI Search
Search for anything
Right click on any result and select 'Copy All'
Paste the copied contents into a file and check if they correspond.