Add inline reference handling for markdown conversion in RunSubagentTool #285020
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #282509 where inline references (file paths) from subagents were being lost during markdown conversion. The fix ensures that when a subagent returns inline references as part of its response, these references are properly preserved and converted to markdown links in the tool result that gets sent back to the orchestrator.
Key Changes:
- Added handling for
inlineReferencekind in the response processing loop alongsidemarkdownContent - Implemented a new
inlineReferenceToMarkdownfunction to convert inline reference objects into markdown link format - Added necessary imports for URI, basename, and isLocation utilities
| label = reference.name ?? basename(reference.location.uri); | ||
| } | ||
| const escapedLabel = label.replace(/[[\]()\\]/g, '\\$&'); | ||
| return `[${escapedLabel}](${refUri.toString()})\n`; |
There was a problem hiding this comment.
I think the formatting is a bit overkill, I think that just giving uri.fsPath would be best, rather than doing a md-link and stringifying a URI. We shouldn't stringify the URI here on the frontend because it will use the internal remote scheme vscode-remote when on a remote. I think the logic can be copied from here: https://github.com/microsoft/vscode-copilot-chat/blob/f809049bb00c86f54f7a2eb0b0be772b8da2ee79/src/platform/prompts/common/promptPathRepresentationService.ts#L47-L52
(fsPath for typical URIs but toString anything out of the ordinary)
2 participants
Add inline reference handling for markdown conversion in RunSubagentTool. Fix #282509
CC: @roblourens