Skip to content

Conversation

@anthonykim1
Copy link
Contributor

@anthonykim1 anthonykim1 commented Dec 9, 2025

Resolves: #278855

@anthonykim1 anthonykim1 added this to the December / January 2026 milestone Dec 9, 2025
@anthonykim1 anthonykim1 self-assigned this Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 06:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new command editor.action.announceCursorPosition that announces the current cursor position (line and column) to screen reader users. This addresses an accessibility need where users want to quickly hear their current cursor location without navigating to the status bar.

Key Changes:

  • New AnnounceCursorPosition action that uses the ARIA alert() function to announce position
  • Integration with accessibility help documentation to inform users about the new command
  • Localized strings for the command title, description, and announcement message

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/contrib/codeEditor/browser/accessibility/accessibility.ts Implements the new AnnounceCursorPosition command that retrieves the cursor position and announces it via screen reader
src/vs/workbench/contrib/accessibility/browser/editorAccessibilityHelp.ts Adds reference to the new command in the accessibility help content
src/vs/editor/common/standaloneStrings.ts Adds localized string for the accessibility help entry with keybinding placeholder

Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test (we should) but LGTM! We should test using status and alert and see how each behaves.

@meganrogge
Copy link
Contributor

Let's go with alert per feedback!

@anthonykim1 anthonykim1 marked this pull request as ready for review January 5, 2026 16:58
@anthonykim1 anthonykim1 requested a review from meganrogge January 5, 2026 16:58
@anthonykim1 anthonykim1 marked this pull request as draft January 5, 2026 17:00
@anthonykim1
Copy link
Contributor Author

Forgot to add keybinding🫢 ctrl/cmd + shift+ g , but I think we should be good to go after that

Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 😄

id: 'editor.action.announceCursorPosition',
title: nls.localize2('announceCursorPosition', "Announce Cursor Position"),
f1: true,
// TODO: Get suggestion on Keybinding!. Something with ctrl+g since people are used to it?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anthonykim1 should we try the keybinding they suggested here?

Copy link
Contributor Author

@anthonykim1 anthonykim1 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap! @meganrogge is
[Add keybinding ctrlCmd+shift+g]0417961 good place to put it?

@anthonykim1 anthonykim1 marked this pull request as ready for review January 5, 2026 18:34
@anthonykim1 anthonykim1 requested a review from meganrogge January 5, 2026 18:34
@anthonykim1 anthonykim1 merged commit 85b4883 into main Jan 5, 2026
22 checks passed
@anthonykim1 anthonykim1 deleted the anthonykim1/commandLineCol branch January 5, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add command to announce the current editor line number via aria.status

3 participants