Skip to content

Retry PET refresh on process crash (ConnectionError), not just timeout #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StellaHuang95 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −10
Open

Retry PET refresh on process crash (ConnectionError), not just timeout #1447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/managers/common/nativePythonFinder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,10 +260,11 @@ class NativePythonFinderImpl implements NativePythonFinder {
this.restartAttempts = 0;
return environment;
} catch (ex) {
// On resolve timeout (not configure — configure handles its own timeout),
// On resolve timeout or connection error (not configure — configure handles its own timeout),
// kill the hung process so next request triggers restart
if (ex instanceof RpcTimeoutError && ex.method !== 'configure') {
this.outputChannel.warn('[pet] Resolve request timed out, killing hung process for restart');
if ((ex instanceof RpcTimeoutError && ex.method !== 'configure') || ex instanceof rpc.ConnectionError) {
const reason = ex instanceof rpc.ConnectionError ? 'crashed' : 'timed out';
this.outputChannel.warn(`[pet] Resolve request ${reason}, killing process for restart`);
this.killProcess();
this.processExited = true;
}
Expand Down Expand Up @@ -574,11 +575,14 @@ class NativePythonFinderImpl implements NativePythonFinder {
} catch (ex) {
lastError = ex;

// Only retry on timeout errors
if (ex instanceof RpcTimeoutError && ex.method !== 'configure') {
// Retry on timeout or connection errors (PET hung or crashed mid-request)
const isRetryable =
(ex instanceof RpcTimeoutError && ex.method !== 'configure') || ex instanceof rpc.ConnectionError;
if (isRetryable) {
if (attempt < MAX_REFRESH_RETRIES) {
const reason = ex instanceof rpc.ConnectionError ? 'crashed' : 'timed out';
this.outputChannel.warn(
`[pet] Refresh timed out (attempt ${attempt + 1}/${MAX_REFRESH_RETRIES + 1}), restarting and retrying...`,
`[pet] Refresh ${reason} (attempt ${attempt + 1}/${MAX_REFRESH_RETRIES + 1}), restarting and retrying...`,
);
// Kill and restart for retry
this.killProcess();
Expand All @@ -588,7 +592,7 @@ class NativePythonFinderImpl implements NativePythonFinder {
// Final attempt failed
this.outputChannel.error(`[pet] Refresh failed after ${MAX_REFRESH_RETRIES + 1} attempts`);
}
// Non-timeout errors or final timeout - rethrow
// Non-retryable errors or final attempt - rethrow
throw ex;
}
}
Expand Down Expand Up @@ -652,10 +656,11 @@ class NativePythonFinderImpl implements NativePythonFinder {
this.outputChannel.info(`[pet] Refresh succeeded on retry attempt ${attempt + 1}`);
}
} catch (ex) {
// On refresh timeout (not configure — configure handles its own timeout),
// On refresh timeout or connection error (not configure — configure handles its own timeout),
// kill the hung process so next request triggers restart
if (ex instanceof RpcTimeoutError && ex.method !== 'configure') {
this.outputChannel.warn('[pet] Request timed out, killing hung process for restart');
if ((ex instanceof RpcTimeoutError && ex.method !== 'configure') || ex instanceof rpc.ConnectionError) {
const reason = ex instanceof rpc.ConnectionError ? 'crashed' : 'timed out';
this.outputChannel.warn(`[pet] PET process ${reason}, killing for restart`);
this.killProcess();
this.processExited = true;
}
Expand Down
Loading