Repository navigation
🐛 Load descriptions before the first overview render - #9054
Open
John Wooten (JFWooten4) wants to merge 6 commits into
Open
John Wooten (JFWooten4) wants to merge 6 commits into
John Wooten (JFWooten4) wants to merge 6 commits into
Conversation
Co-authored-by: Codex <noreply@openai.com>
Discard description and initialization results after an overview closes or a newer request replaces it, and add GraphQL hydration and race regression coverage. Co-authored-by: Codex Web <noreply@openai.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation addresses the blank-description race with focused safeguards and comprehensive regression tests.
0 open findings
What changed in this PR
Ensures pull request descriptions are hydrated before the overview’s initial render while preventing stale asynchronous updates.
Changes:
- Fetches missing rendered description HTML before initialization.
- Adds stale-update and disposal guards.
- Adds regression coverage for hydration, failures, and races.
| File | Description |
|---|---|
src/github/pullRequestOverview.ts |
Hydrates descriptions and guards asynchronous updates. |
src/test/github/pullRequestOverview.test.ts |
Covers description loading and stale-result scenarios. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
John Wooten (JFWooten4)
left a comment
Author
There was a problem hiding this comment.
@microsoft-github-policy-service agree
Integrate description hydration and stale-update guards with the latest upstream stack-prefetch workflow. Retain upstream changes and carry forward description and race regression tests. Co-authored-by: ChatGPT 6 <noreply@openai.com>
The PR adds regression coverage for loading description HTML before initialization and ignoring stale asynchronous overview loads. Upstream adds branch-label coverage for single and multiple repositories and forked pull requests at the same insertion point. Preserve both independent test groups so the description fix and the newer overview labels remain covered. Validation: TypeScript test compilation and all three webpack targets pass; 1,379 extension tests, 130 webview tests and 75 script tests pass.
Co-authored-by: Codex <noreply@openai.com>
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Possibly related to #9049: pull request descriptions load after the overview is initially rendered, so descriptions appear blank.
Output
The changes also guards against stale asynchronous results to prevent outdated data from updating a closed or superseded overview.