chore(deps-dev): bump typescript from 4.9.5 to 7.0.2 - #1688
chore(deps-dev): bump typescript from 4.9.5 to 7.0.2#1688dependabot[bot] wants to merge 4 commits into
Conversation
Bumps [typescript](https://github.com/microsoft/TypeScript) from 4.9.5 to 7.0.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v4.9.5...v7.0.2) --- updated-dependencies: - dependency-name: typescript dependency-version: 7.0.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Use the native TypeScript 7 compiler for type-checking while retaining the official TypeScript 6 compatibility API for TSLint and ts-loader. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
left a comment
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
The TypeScript 7 compatibility migration is focused, preserves the legacy compiler API for TSLint and ts-loader, and passes all required checks.
There was a problem hiding this comment.
🔵 Needs a closer look
The TypeScript upgrade introduces a dual-compiler setup (TypeScript 7 for tsc vs TypeScript 6 for ts-loader/require("typescript")) and needs a deliberate compatibility decision before it can be safely approved.
Pull request overview
Updates the repository’s TypeScript toolchain to accommodate a major TypeScript upgrade, including build-script changes and a raised Node.js prerequisite.
Changes:
- Adds a TypeScript 7.x install via an npm alias and adjusts
compileto invoke that compiler. - Tweaks test harness imports to CommonJS-style
import = require(...). - Updates TS compiler options and bumps the documented minimum Node.js version.
File summaries
| File | Description |
|---|---|
| tsconfig.json | Adds explicit strictness-related compiler option overrides. |
| test/suite/index.ts | Switches glob/mocha imports to import = require(...). |
| package.json | Updates TypeScript-related devDependencies and changes the compile script to use the aliased compiler. |
| package-lock.json | Adds the new aliased TypeScript package and its platform-specific optional dependencies. |
| CONTRIBUTING.md | Updates the documented minimum Node.js version. |
Review details
- Files reviewed: 3/5 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Declare the test runner glob dependency directly and document the intentional TypeScript 6 compatibility API used by legacy build tools. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The documented Node.js minimum is inconsistent with engine requirements in the lockfile, and the TS/glob dependency strategy introduces mismatches (including a deprecated glob version) that should be resolved/clarified before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
package.json:1398
- The PR title/description says TypeScript is bumped to 7.0.2, but the
typescriptdevDependency is set tonpm:@typescript/typescript6@^6.0.2(with TypeScript 7 added separately as @typescript/native). This is likely to confuse maintainers and tooling (require('typescript')will resolve to TS6). Consider aligning the PR metadata with the dual-compiler approach, or switchingtypescriptitself to 7.x and introducing the compatibility compiler under a different alias.
"typescript": "npm:@typescript/typescript6@^6.0.2",
- Files reviewed: 3/5 changed files
- Comments generated: 3
- Review effort level: Lite
Align the development runtime with CI, use the public TypeScript compiler bin, and migrate test discovery to the supported glob API. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The compile script currently runs the TypeScript 7 native tsc via node, which should fail at runtime and break npm test/CI.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
package.json:1397
- PR title/description says TypeScript is bumped to 7.0.2, but the
typescriptdevDependency is set tonpm:@typescript/typescript6@^6.0.2(and 7.0.2 is pulled in under the alias@typescript/native). That mismatch is likely to confuse tooling and maintainers (e.g. anything checking thetypescriptversion from package.json) and makes the PR metadata misleading.
"typescript": "npm:@typescript/typescript6@^6.0.2",
- Files reviewed: 3/5 changed files
- Comments generated: 1
- Review effort level: Lite
Changyong Gong (chagong)
left a comment
Changyong Gong (chagong)
left a comment
There was a problem hiding this comment.
The final TypeScript 7 compatibility migration is focused, all review findings are addressed or disproven by current-head evidence, and all required checks pass.
Bumps typescript from 4.9.5 to 7.0.2.
Release notes
Sourced from typescript's releases.
... (truncated)
Commits
1e4744dMerge branch 'main' into ts7-releasea5a219cmicrosoft/typescript-go#4558ecfe30dUpdate status localization5de25b5Hide executable name in TypeScript statusd7ce74aShow bundled TypeScript version for packaged servers29be66aCorrect TS 7 release version to 7.0.2ed2bd1bMerge branch 'main' into ts7-release8873075Bump the github-actions group across 1 directory with 3 updates (microsoft/ty...9427131Set up stable / nightly extension split, other prep (microsoft/typescript-go#...d4eaca5microsoft/typescript-go#4549Maintainer changes
This version was pushed to npm by microsoft1es, a new releaser for typescript since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)