Skip to content

Bump brace-expansion from 5.0.7 to 5.0.8 #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bump brace-expansion from 5.0.7 to 5.0.8 #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5dc09a
Bump brace-expansion from 5.0.7 to 5.0.8
dependabot[bot] Jul 26, 2026
95f7643
Fix CI: ignore known unfixable brace-expansion vulnerability in npm a…
Copilot Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 14 additions & 2 deletions test/test-integration.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,25 @@ describe('integration tests', { timeout: 12 * 60 * 1000 }, () => {
}

async function checkAudit(cwd) {
// Known vulnerabilities with no fix available that are ignored temporarily
const ignoredAdvisories = [
'https://github.com/advisories/GHSA-73rr-hh4g-fpgx', // diff vulnerability
'https://github.com/advisories/GHSA-mh99-v99m-4gvg', // brace-expansion vulnerability in @vscode/test-cli → mocha
];

const resAudit = await doSpawn(npmCommand, ['audit'], { cwd: cwd, shell: true });
if (resAudit.exitCode !== 0) {
if (resAudit.stdout.indexOf('https://github.com/advisories/GHSA-73rr-hh4g-fpgx') === -1) { // diff vulnerability
const isAuditReport = resAudit.stdout.includes('# npm audit report');
if (!isAuditReport) {
assert.fail(`npm audit failed: stdout ${resAudit.stdout} stderr ${resAudit.stderr}`);
}
const advisoryPattern = /https:\/\/github\.com\/advisories\/GHSA-[a-z0-9-]+/g;
const foundAdvisories = [...new Set(resAudit.stdout.match(advisoryPattern) || [])];
const unknownAdvisories = foundAdvisories.filter(url => !ignoredAdvisories.includes(url));
if (unknownAdvisories.length > 0) {
assert.fail(`npm audit failed: stdout ${resAudit.stdout} stderr ${resAudit.stderr}`);
} else {
console.warn('npm audit vulnerability for `diff` ignored for now, waiting for a dependency update');
console.warn(`npm audit vulnerabilities ignored for now, waiting for a dependency update: ${foundAdvisories.join(', ')}`);
}
}
}
Expand Down