Safely destructure custom agents response to handle null/undefined. Fix https://github.com/microsoft/vscode/issues/274437 #1746
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the getCustomAgents method in the OctoKitService class to add an unnecessary object spread operation when destructuring the response from getCustomAgentsWithToken.
Key Changes
- Added object spread syntax when destructuring the
agentsproperty from the API response
…/undefined responses
roblourens
reviewed
Nov 3, 2025
Member
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Thanks for the PR! But should this happen in getCustomAgentsWithToken? Or does that method have the wrong return signature? TS should have helped us here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safely destructure custom agents response to handle null/undefined. Fix microsoft/vscode#274437