Skip to content

cloud agent: fix tool call parsing #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cloud agent: fix tool call parsing #1696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bbc0df
fix tool call parsing
rebornix Oct 29, 2025
b679fff
fix create file tool call rendering
rebornix Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions src/extension/chatSessions/vscode-node/copilotCloudSessionContentBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,25 +480,14 @@ export class ChatSessionContentBuilder {
};
};

const buildStrReplaceDetails = (filePath: string | undefined): ParsedToolCallDetails => {
const fileLabel = filePath && this.toFileLabel(filePath);
const message = fileLabel ? `Edit [](${fileLabel})` : `Edit ${filePath}`;
return {
toolName: 'Edit',
invocationMessage: message,
pastTenseMessage: message,
toolSpecificData: fileLabel ? { command: 'str_replace', filePath, fileLabel } : undefined
};
};

const buildCreateDetails = (filePath: string | undefined): ParsedToolCallDetails => {
const fileLabel = filePath && this.toFileLabel(filePath);
const message = fileLabel ? `Create [](${fileLabel})` : `Create File ${filePath}`;
return {
toolName: 'Create',
invocationMessage: message,
pastTenseMessage: message,
toolSpecificData: fileLabel ? { command: 'create', filePath, fileLabel } : undefined
toolSpecificData: fileLabel ? { command: 'edit', filePath, fileLabel, viewRange: undefined } : undefined
};
};

Expand Down Expand Up @@ -570,7 +559,7 @@ export class ChatSessionContentBuilder {
return buildEditDetails(args.path, args.command || 'edit', this.parseRange(args.view_range));
}
case 'str_replace':
return buildStrReplaceDetails(args.path);
return buildEditDetails(args.path, 'edit', undefined, { defaultName: 'Edit' });
case 'create':
return buildCreateDetails(args.path);
case 'view':
Expand All @@ -590,6 +579,13 @@ export class ChatSessionContentBuilder {
return { toolName: 'read_bash', invocationMessage: 'Read logs from Bash session' };
case 'stop_bash':
return { toolName: 'stop_bash', invocationMessage: 'Stop Bash session' };
case 'run_custom_setup_step':
case 'run_setup':
return { toolName: 'run_custom_setup_step', invocationMessage: content || 'Run custom setup step' };
case 'github-mcp-server-search_code':
return { toolName: 'github-mcp-server-search_code', invocationMessage: 'Search code on GitHub' };
case 'code_review':
return { toolName: 'code_review', invocationMessage: 'Review changes with Copilot code review' };
default:
return { toolName: name || 'unknown', invocationMessage: content || name || 'unknown' };
}
Expand Down
Loading