image attachment support for CLI #1541
+156
−33
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| import * as vscode from 'vscode'; | ||
| import { IVSCodeExtensionContext } from '../../../platform/extContext/common/extensionContext'; | ||
| import { URI } from '../../../util/vs/base/common/uri'; | ||
|
|
||
| export class ImageStorage { | ||
| private readonly storageDir: URI; | ||
|
|
||
| constructor(private readonly context: IVSCodeExtensionContext) { | ||
| this.storageDir = URI.joinPath(this.context.globalStorageUri, 'copilot-cli-images'); | ||
| this.initialize(); | ||
| } | ||
|
|
||
| private async initialize(): Promise<void> { | ||
| try { | ||
| await vscode.workspace.fs.createDirectory(this.storageDir); | ||
| await this.cleanupOldImages(); | ||
| } catch (error) { | ||
| console.error('ImageStorage: Failed to initialize', error); | ||
| } | ||
| } | ||
|
Comment on lines
+10
to
+25
There was a problem hiding this comment. The
The class should inject these services in the constructor to maintain consistency with the project's service-oriented architecture. |
||
|
|
||
| async storeImage(imageData: Uint8Array, mimeType: string): Promise<URI> { | ||
| const timestamp = Date.now(); | ||
| const randomId = Math.random().toString(36).substring(2, 10); | ||
| const extension = this.getExtension(mimeType); | ||
| const filename = `${timestamp}-${randomId}${extension}`; | ||
| const imageUri = URI.joinPath(this.storageDir, filename); | ||
|
|
||
| await vscode.workspace.fs.writeFile(imageUri, imageData); | ||
| return imageUri; | ||
| } | ||
|
|
||
| async getImage(uri: URI): Promise<Uint8Array | undefined> { | ||
| try { | ||
| const data = await vscode.workspace.fs.readFile(uri); | ||
| return data; | ||
| } catch { | ||
| return undefined; | ||
| } | ||
| } | ||
|
|
||
| async deleteImage(uri: URI): Promise<void> { | ||
| try { | ||
| await vscode.workspace.fs.delete(uri); | ||
| } catch { | ||
| // Already deleted | ||
| } | ||
| } | ||
|
|
||
| async cleanupOldImages(maxAgeMs: number = 7 * 24 * 60 * 60 * 1000): Promise<void> { | ||
| try { | ||
| const entries = await vscode.workspace.fs.readDirectory(this.storageDir); | ||
| const now = Date.now(); | ||
| const cutoff = now - maxAgeMs; | ||
|
|
||
| for (const [filename, fileType] of entries) { | ||
| if (fileType === vscode.FileType.File) { | ||
| const fileUri = URI.joinPath(this.storageDir, filename); | ||
| try { | ||
| const stat = await vscode.workspace.fs.stat(fileUri); | ||
| if (stat.mtime < cutoff) { | ||
| await vscode.workspace.fs.delete(fileUri); | ||
|
Collaborator
There was a problem hiding this comment. Would be more efficient to do a Promise.all(..) |
||
| } | ||
| } catch { | ||
| // Skip files we can't access | ||
| } | ||
| } | ||
| } | ||
| } catch (error) { | ||
| console.error('ImageStorage: Failed to cleanup old images', error); | ||
|
Comment on lines
+23
to
+75
There was a problem hiding this comment. Using |
||
| } | ||
| } | ||
|
|
||
| private getExtension(mimeType: string): string { | ||
| const map: Record<string, string> = { | ||
| 'image/png': '.png', | ||
| 'image/jpeg': '.jpg', | ||
| 'image/jpg': '.jpg', | ||
| 'image/gif': '.gif', | ||
| 'image/webp': '.webp', | ||
| 'image/bmp': '.bmp', | ||
| }; | ||
| return map[mimeType.toLowerCase()] || '.bin'; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
initialize()method is called in the constructor but is async and not awaited. This means the storage directory creation and cleanup may not complete beforestoreImage()is called, potentially causing file operation failures. Consider making initialization synchronous or ensuring it completes before allowing image storage operations.