Skip to content

Make more completions core tests pass #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make more completions core tests pass #1285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
269f2c3
Make more completions core tests pass
dbaeumer Oct 10, 2025
31a5066
Fix ?? operator
dbaeumer Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,8 @@
"--disable-extensions"
],
"env": {
"TSX_TSCONFIG_PATH": "${workspaceFolder}/tsconfig.json"
"TSX_TSCONFIG_PATH": "${workspaceFolder}/tsconfig.json",
"CORETEST": "true"
},
"internalConsoleOptions": "openOnSessionStart",
"outFiles": [
Expand Down
2 changes: 1 addition & 1 deletion test/base/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
const compress = promisify(zlib.brotliCompress);
const decompress = promisify(zlib.brotliDecompress);

const DefaultCachePath = process.env.VITEST ? path.resolve(__dirname, '..', 'simulation', 'cache') : path.resolve(__dirname, '..', 'test', 'simulation', 'cache');
const DefaultCachePath = (process.env.VITEST ?? process.env.CORETEST) ? path.resolve(__dirname, '..', 'simulation', 'cache') : path.resolve(__dirname, '..', 'test', 'simulation', 'cache');

async function getGitRoot(cwd: string): Promise<string> {
const execAsync = promisify(exec);
Expand Down Expand Up @@ -244,7 +244,7 @@
// Check git for an uncommitted layer database file
try {
const gitRoot = await getGitRoot(activeLayerPath);
const { stdout: statusStdout } = await execAsync(`git status -z ${gitStatusPath}`, { cwd: gitRoot });

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium test

This shell command depends on an uncontrolled
absolute path
Loading
.
This shell command depends on an uncontrolled
absolute path
Loading
.
if (statusStdout !== '') {
const layerDatabaseEntries = statusStdout.split('\0').filter(entry => entry.endsWith('.sqlite'));
if (layerDatabaseEntries.length > 0) {
Expand Down
Loading