fix: resolve default values from emitter options JSON schema#9971
Draft
fix: resolve default values from emitter options JSON schema#9971
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal fix — only 4 files changed, no breaking changes to existing tests.
Changes Made
schema-validator.ts: AdduseDefaultsoption toJSONSchemaValidatorOptionsinterface and pass it through to AJV (+2 lines)library.ts: EnableuseDefaults: truewhen creating the emitter option validator (+1 line)emitter-options.test.ts: Add 3 test cases for schema defaults — applies defaults when no options provided, user values override defaults, and partial defaults for missing options (+76 lines)@typespec/compilerHow It Works
The fix enables AJV's built-in
useDefaultsoption specifically for the emitter option validator. When an emitter definesdefaultvalues in its JSON schema options, those defaults are now applied tocontext.optionsduring$onEmit. This is a non-breaking, additive change — existing emitters withoutdefaultvalues in their schemas are unaffected.Testing
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.