APIVersion and MaxpAgeSize Parameter handling #9523
+21
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
Contributor
|
No changes needing a change description found. |
radhgupta
requested review from
JoshLove-msft,
christothes,
jorgerangel-msft,
jsquire and
m-nash
as code owners
JoshLove-msft
approved these changes
Jan 29, 2026
| } | ||
|
|
||
| // Check if this is a max page size parameter | ||
| if (pagingServiceMethod?.PagingMetadata.PageSizeParameterSegments?.Count > 0) |
Contributor
There was a problem hiding this comment.
nit: we can probably consolidate this code that gets the MaxPageSizeParameter in a method as I believe it is used elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how special query parameters, particularly API version and max page size, are detected and handled in the
RestClientProviderclass. The changes improve the flexibility and accuracy of parameter updates, especially for paging operations, by relying on parameter metadata rather than hardcoded string comparisons.Parameter handling improvements:
ShouldUpdateReinjectedParameterto use parameter metadata (IsApiVersionand paging metadata) instead of comparing against hardcoded strings.ShouldUpdateReinjectedParameterinAppendQueryParametersto pass the fullInputParameterandInputPagingServiceMethod, enabling the new metadata-based logic.