-
Notifications
You must be signed in to change notification settings - Fork 334
Add Spector tests for File type with content type variations #9513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
…to multipart spec Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
| contentType: "image/png"; | ||
| } | ||
|
|
||
| model FileWithMultipleContentTypes extends TypeSpec.Http.File { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot rename this one to FileWithRequiredFilename and keep only a single content type. Use the template argument to set it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 107bfbd. Renamed to FileWithRequiredFilename and changed to use template argument: extends TypeSpec.Http.File<"image/png">.
…ename, remove FileWithRequiredMetadata Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
commit: |
…tion/octet-stream Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot please run |
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Done in 651bc95. Ran Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot you also need to add a changelog entry in .chronus/changes/ with |
Co-authored-by: timotheeguerin <1031227+timotheeguerin@users.noreply.github.com>
Done in 4d4afda. Added changelog entry using |
Final Changes - Ready for Merge ✅
Changelog Entry Added ✅
Added changelog entry using
pnpm change add:@typespec/http-specsCode Formatting ✅
Ran
pnpm formatto format the code according to project standards.Complete Test Coverage
Body Tests (8 scenarios in
/type/file):image/png)application/json)image/png | image/jpeg)image/pngfor testing)Multipart Tests (3 scenarios in
/payload/multipart):All PR Feedback Addressed
/payload/multipartHttp.File<>syntax instead of model wrappersFileWithRequiredFilenamewith template argumentimage/pngpnpm formatpnpm change addValidation
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.