Skip to content

Fix C# constructor parameter name back compatibility - #11606

Draft
Wei Hu (live1206) wants to merge 7 commits into
microsoft:mainfrom
live1206:fix/csharp-constructor-parameter-names
Draft

Fix C# constructor parameter name back compatibility#11606
Wei Hu (live1206) wants to merge 7 commits into
microsoft:mainfrom
live1206:fix/csharp-constructor-parameter-names

Conversation

@live1206

Copy link
Copy Markdown
Contributor

Summary

  • restore generated constructor parameter names positionally from the previous contract
  • apply swaps and rotations atomically after validating final names are unique
  • preserve constructor body and XML documentation references through parameter updates
  • cover simple renames, casing changes, swaps, rotations, type mismatches, and duplicate-name rejection

Fixes #11588

- by copilot

@github-actions

Copy link
Copy Markdown
Contributor

No changes needing a change description found.

@azure-sdk-automation

Copy link
Copy Markdown

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@live1206
Wei Hu (live1206) force-pushed the fix/csharp-constructor-parameter-names branch from 8be0bd5 to c45fa0e Compare August 10, 2026 03:49
@pkg-pr-new

pkg-pr-new Bot commented Aug 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@11606

commit: 8a5f57c

@live1206
Wei Hu (live1206) marked this pull request as draft August 10, 2026 09:46
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: eefce9bd-b052-451e-9208-2781435428a1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: eefce9bd-b052-451e-9208-2781435428a1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: eefce9bd-b052-451e-9208-2781435428a1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: eefce9bd-b052-451e-9208-2781435428a1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: eefce9bd-b052-451e-9208-2781435428a1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: eefce9bd-b052-451e-9208-2781435428a1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: eefce9bd-b052-451e-9208-2781435428a1
@live1206
Wei Hu (live1206) force-pushed the fix/csharp-constructor-parameter-names branch from 2b29cb5 to 8a5f57c Compare August 10, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore previous GA parameter names on generated constructors

1 participant