Skip to content

Spector datetime matchers#10011

Open
timotheeguerin wants to merge 28 commits intomicrosoft:mainfrom
timotheeguerin:feat/spector-matchers
Open

Spector datetime matchers#10011
timotheeguerin wants to merge 28 commits intomicrosoft:mainfrom
timotheeguerin:feat/spector-matchers

Conversation

@timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Mar 12, 2026

fix #9997

@microsoft-github-policy-service microsoft-github-policy-service bot added lib:http-specs For issues/prs related to the @typespec/http-specs package spector Issues related to spector and the spec sets labels Mar 12, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 12, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-specs@10011

npm i https://pkg.pr.new/@typespec/spec-api@10011

npm i https://pkg.pr.new/@typespec/spector@10011

commit: b62486d

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/http-specs
  • ✅ @typespec/spec-api
  • ✅ @typespec/spector
Show changes

@typespec/spec-api - feature ✏️

Add matcher framework for flexible value comparison in scenarios. match.dateTime() enables semantic datetime comparison that handles precision and timezone differences across languages.

@typespec/spector - feature ✏️

Add matcher framework for flexible value comparison in scenarios. match.dateTime() enables semantic datetime comparison that handles precision and timezone differences across languages.

@typespec/http-specs - feature ✏️

Add matcher framework for flexible value comparison in scenarios. match.dateTime() enables semantic datetime comparison that handles precision and timezone differences across languages.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 12, 2026 •
edited
Loading

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

@weidongxu-microsoft weidongxu-microsoft mentioned this pull request Mar 15, 2026
Draft
3 tasks
@timotheeguerin timotheeguerin marked this pull request as ready for review March 17, 2026 13:41
markcowl
markcowl reviewed Mar 18, 2026
View reviewed changes
Copy link
Contributor

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions about ISO datetimes, otherwise, lgtm

packages/http-specs/specs/payload/pageable/mockapi.ts
},
]);

const xmlNextLinkFirstPage = (baseUrl: string) => `
Copy link
Contributor

@markcowl markcowl Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these changes belong in this PR?

Copy link
Member Author

@timotheeguerin timotheeguerin Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah pr also make base url a matcher which cleans that up

packages/http-specs/specs/payload/pageable/mockapi.ts
request: {},
response: {
status: 200,
body: {
Copy link
Contributor

@markcowl markcowl Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these belong in this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markcowl markcowl markcowl left review comments

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek chrisradek is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

lib:http-specs For issues/prs related to the @typespec/http-specs package spector Issues related to spector and the spec sets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spector better handling for non consistent types

3 participants

@timotheeguerin @azure-sdk @markcowl