Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant NodeFlagsHasJSDoc guard checks at several call sites by relying on ast.Node.JSDoc / ast.Node.EagerJSDoc to short-circuit and return nil when JSDoc is not present.
Changes:
- Simplify selection range traversal to always iterate
current.JSDoc(sourceFile)without a separate flag check. - Simplify checker JSDoc comment validation to always iterate
node.EagerJSDoc(nil)without a separate flag check. - Simplify AST navigation helpers that visit children + JSDoc to always iterate
node.JSDoc(sourceFile)without a separate flag check.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/ls/selectionranges.go | Removes redundant HasJSDoc check before iterating JSDoc nodes during selection range computation. |
| internal/checker/checker.go | Removes redundant HasJSDoc check before iterating eager JSDoc nodes during source element checking. |
| internal/astnav/tokens.go | Removes redundant HasJSDoc check in VisitEachChildAndJSDoc. |
| internal/ast/utilities.go | Removes redundant HasJSDoc check in ForEachChildAndJSDoc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are redundant;
JSDocandEagerJSDocboth check this and return nil.