Skip to content

Port TS PR #62669: Deprecate --module amd, umd, system, none; --moduleResolution classic#2818

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/deprecate-module-types
Draft

Port TS PR #62669: Deprecate --module amd, umd, system, none; --moduleResolution classic#2818
Copilot wants to merge 2 commits intomainfrom
copilot/deprecate-module-types

Conversation

Copy link
Contributor

Copilot AI commented Feb 18, 2026

Ports applicable parts of microsoft/TypeScript#62669 to the Go port.

Changes

  • Mark --module values as deprecated: Added none, amd, system, umd to commandLineOptionDeprecated, filtering them from --help output and error suggestion text
  • Add removal diagnostic for --moduleResolution classic: Emits "has been removed" when explicitly set, consistent with existing node10 handling
  • Update commented-out bundler check: Synced the dormant validation to match current TS (new diagnostic message, CommonJS exclusion)

Not ported

  • module: None removal diagnostic: ModuleKindNone = 0 is Go's zero value — indistinguishable from "not set"
  • GetModuleResolutionKind default change (deprecated modules → Classic): Classic resolution is unimplemented in the Go resolver; deprecated modules continue mapping to Bundler
  • completions.ts changes: Go port uses a different auto-import origin structure without Export/ResolvedExport flags

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…eResolution classic

- Add deprecated keys for module option (none, amd, system, umd)
- Add removal diagnostic for moduleResolution classic
- Update commented-out bundler check with new diagnostic and CommonJS exclusion
- Accept baseline changes for help output and error messages

Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copilot AI changed the title [WIP] Port deprecation of module types and resolution settings Port TS PR #62669: Deprecate --module amd, umd, system, none; --moduleResolution classic Feb 18, 2026
Copilot AI requested a review from jakebailey February 18, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments