Skip to content

Fix failing GitHub Actions job build-unittest #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robgruen merged 2 commits into from
Oct 14, 2026
Merged

Fix failing GitHub Actions job build-unittest #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3705ee
Initial plan
Copilot Oct 14, 2026
1811822
Remove vulnerable legacy SourceLink package override
Copilot Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
<PackageVersion Include="coverlet.collector" Version="3.2.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="5.0.0" />
<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<!--
Microsoft.Bcl.Memory is pinned via central transitive pinning to
remediate GHSA-73j8-2gch-69rq (CVE-2026-26127, .NET DoS in
Expand Down
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ Prior versions of TypeChat.NET used the pre-release programming model of Semanti

## Building

Use a serviced .NET SDK 8 or newer, including when building from Visual Studio.
[Source Link is included in .NET SDK 8+](https://github.com/dotnet/sourcelink#using-source-link-in-net-projects),
so the projects use its SDK-provided implementation rather than overriding it with legacy NuGet packages.

* Visual Studio 2022.
* Load **typechat.sln** from the root directory.
* Restore packages
Expand Down
7 changes: 1 addition & 6 deletions src/package/nuget.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<PackageReadmeFile>NUGET.md</PackageReadmeFile>

<!-- Build symbol package (.snupkg) to distribute the PDB containing Source Link -->
<!-- .NET SDK 8+ supplies Source Link; legacy package references override its serviced version. -->
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>

Expand All @@ -28,12 +29,6 @@
<DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>
</PropertyGroup>

<ItemGroup>
<!-- SourceLink allows step-through debugging for source hosted on GitHub. -->
<!-- https://github.com/dotnet/sourcelink -->
<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" />
</ItemGroup>

<ItemGroup>
<!-- Include icon.png and NUGET.md in the project. -->
<None Include="../package/icon.png" Link="icon.png" Pack="true" PackagePath="." />
Expand Down
Loading