Skip to content

fix(shortcut): resource acc test should use WorkspaceRS #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(shortcut): resource acc test should use WorkspaceRS #634

wants to merge 1 commit into from
+67 −36

Conversation

@catalina-gav
Copy link
Contributor

@catalina-gav catalina-gav commented Sep 2, 2025

📥 Pull Request

❓ What are you trying to address

Use WorkspaceRS for shortcut resource creation acc test instead of workspace DS

@catalina-gav catalina-gav self-assigned this Sep 2, 2025
@catalina-gav catalina-gav added the skip-changelog Skip changelog entry label Sep 2, 2025
Copilot AI review requested due to automatic review settings September 2, 2025 10:23
@catalina-gav catalina-gav requested a review from a team as a code owner September 2, 2025 10:23
Copilot AI reviewed Sep 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the shortcut resource acceptance test to use WorkspaceRS instead of workspace data source for resource creation. The change improves test isolation by creating dedicated lakehouse resources instead of relying on shared test data.

Key changes:

  • Switch from using workspace data source to WorkspaceRS for workspace ID lookup
  • Create dedicated lakehouse resources dynamically within the test
  • Separate workspace concerns by using different workspace IDs for the main resource and target references

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
internal/services/shortcut/resource_shortcut_test.go Updated acceptance test to use WorkspaceRS and create dedicated lakehouse resources
internal/services/shortcut/base_test.go Added helper function to generate lakehouse resources for tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 84% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 66% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 54% 0 ➖
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 50% 0 ➖
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 69% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/functions 75% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 75% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/tftypeinfo 75% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 75% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 90% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/client 91% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider 79% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 63% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/activator 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/apacheairflowjob 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 84% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/copyjob 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/dataflow 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/deploymentpipeline 68% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/deploymentpipelinera 70% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/digitaltwinbuilder 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/domain 77% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/domainra 59% 0 ➖
github.com/microsoft/terraform-provider-fabric/internal/services/domainwa 71% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/environment 86% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 93% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventstreamsourceconnection 83% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/folder 75% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/gateway 79% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/gatewayra 55% 0 ➖
github.com/microsoft/terraform-provider-fabric/internal/services/graphqlapi 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqldashboard 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 87% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/lakehousetable 80% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mirroreddatabase 84% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mounteddatafactory 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/shortcut 78% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkcustompool 70% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkenvsettings 79% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 89% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkwssettings 83% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sqldatabase 90% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 91% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 79% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspacegit 69% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspacempe 77% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspacera 76% 0 ✔
Summary 77% (15673 / 20471) 0 ✔

Minimum allowed line rate is 40%

OrBaubergMicrosoft
OrBaubergMicrosoft reviewed Sep 8, 2025
View reviewed changes
internal/services/shortcut/base_test.go
)

var itemTypeInfo = shortcut.ItemTypeInfo

Copy link
Collaborator

@OrBaubergMicrosoft OrBaubergMicrosoft Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OrBaubergMicrosoft OrBaubergMicrosoft OrBaubergMicrosoft left review comments

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@catalina-gav catalina-gav

Labels

skip-changelog Skip changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@catalina-gav @OrBaubergMicrosoft