Skip to content

Improve logging during job submission#13

Merged
fepegar merged 1 commit into
mainfrom
fperezgarcia/improve-logging
Jun 8, 2026
Merged

Improve logging during job submission#13
fepegar merged 1 commit into
mainfrom
fperezgarcia/improve-logging

Conversation

@fepegar

@fepegar fepegar commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the CLI’s user-facing logging and progress reporting during Azure ML job submission by replacing Loguru usage with a small Rich-backed logger, adding indentation/spinner-aware timing helpers, and improving exception reporting.

Changes:

  • Replace loguru with a custom Rich-based logger (glyph-prefixed, indented output via a shared Console).
  • Consolidate timing/progress reporting into a single report_time(...) context manager with optional spinner support and nested indentation.
  • Improve job submission UX: print a Rich summary table after submission and emit a concise error panel + write full tracebacks to a temp log file.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_environment.py Updates test comment to reflect logger refactor.
src/submit_aml/progress.py Reworks timing/progress context manager to support spinner + indentation.
src/submit_aml/logger.py Introduces custom Rich-backed logger + indentation depth tracking.
src/submit_aml/errors.py Adds user-friendly exception reporting with traceback log file output.
src/submit_aml/environment.py Wraps environment lookup/registration steps with report_time.
src/submit_aml/data.py Wraps data asset retrieval with report_time.
src/submit_aml/aml.py Improves submission logging (no spinner during SDK uploads) and prints a job summary table.
src/submit_aml/main.py Routes top-level submission failures through report_exception and exits cleanly.
pyproject.toml Drops the loguru dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/submit_aml/progress.py
Comment thread src/submit_aml/aml.py
@fepegar fepegar merged commit 6bbbd33 into main Jun 8, 2026
16 checks passed
@fepegar fepegar deleted the fperezgarcia/improve-logging branch June 8, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants