Improve logging during job submission#13
Merged
Conversation
|
📖 Docs preview: https://smokeshow.helpmanual.io/3r6b1p2k6c3n5d2m5u5y/ |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the CLI’s user-facing logging and progress reporting during Azure ML job submission by replacing Loguru usage with a small Rich-backed logger, adding indentation/spinner-aware timing helpers, and improving exception reporting.
Changes:
- Replace
loguruwith a custom Rich-basedlogger(glyph-prefixed, indented output via a sharedConsole). - Consolidate timing/progress reporting into a single
report_time(...)context manager with optional spinner support and nested indentation. - Improve job submission UX: print a Rich summary table after submission and emit a concise error panel + write full tracebacks to a temp log file.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_environment.py | Updates test comment to reflect logger refactor. |
| src/submit_aml/progress.py | Reworks timing/progress context manager to support spinner + indentation. |
| src/submit_aml/logger.py | Introduces custom Rich-backed logger + indentation depth tracking. |
| src/submit_aml/errors.py | Adds user-friendly exception reporting with traceback log file output. |
| src/submit_aml/environment.py | Wraps environment lookup/registration steps with report_time. |
| src/submit_aml/data.py | Wraps data asset retrieval with report_time. |
| src/submit_aml/aml.py | Improves submission logging (no spinner during SDK uploads) and prints a job summary table. |
| src/submit_aml/main.py | Routes top-level submission failures through report_exception and exits cleanly. |
| pyproject.toml | Drops the loguru dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.