Repository navigation
Python: Build array and mapping schemas for collections.abc Sequence and Mapping - #14796
Open
Hardik K (hardikkaurani) wants to merge 7 commits into
Open
Hardik K (hardikkaurani) wants to merge 7 commits into
Hardik K (hardikkaurani) wants to merge 7 commits into
Conversation
…KernelJsonSchemaBuilder
…rnelJsonSchemaBuilder
Hardik K (hardikkaurani)
deployed
to
github-app-auth
November 15, 2026 11:45 — with
GitHub Actions
Active
Contributor
Author
|
Could you please take a look when you have a moment? This PR enables All unit tests and lint checks pass cleanly locally. Thank you for your review! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In Python, function parameters annotated with abstract collections such as
collections.abc.Sequence[T],collections.abc.MutableSequence[T],collections.abc.Mapping[str, V], orcollections.abc.MutableMapping[str, V](or theirtypingcounterparts) previously failed to produce typed container schemas inKernelJsonSchemaBuilder.Instead,
Sequence[T]andMapping[str, V]fell through tocls.get_json_schema(parameter_type)and were emitted as bare{"type": "object", "properties": {}}schemas. This told LLMs that the parameters expect empty objects instead of typed arrays or typed key-value mappings. Additionally, generic aliases overcollections.abcclasses expose__annotations__, causingKernelJsonSchemaBuilder.buildto route them tobuild_model_schemabefore inspecting their origin.Description
handle_complex_typebeforehasattr(parameter_type, "__annotations__")by checkingget_origin(parameter_type) is not None or hasattr(parameter_type, "__args__").handle_complex_typeto recognizeSequenceandMutableSequence, emitting standard{"type": "array", "items": ...}schemas.handle_complex_typeto recognizeMappingandMutableMapping, emitting standard{"type": "object", "additionalProperties": ...}schemas.tests/unit/schema/test_schema_builder.pycoveringSequence,MutableSequence,Mapping,MutableMapping, optional wrappers, descriptions, and structured output flags.Contribution Checklist