Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,14 @@ class OnnxGenAIPromptExecutionSettings(PromptExecutionSettings):
diversity_penalty: Annotated[float | None, Field(ge=0.0, le=1.0)] = None
do_sample: bool = False
early_stopping: bool = True
length_penalty: Annotated[float | None, Field(ge=0.0, le=1.0)] = None
length_penalty: float | None = None
max_length: Annotated[int, Field(gt=0)] = 3072
min_length: Annotated[int | None, Field(gt=0)] = None
no_repeat_ngram_size: int = 0
num_beams: Annotated[int | None, Field(gt=0)] = None
num_return_sequences: Annotated[int | None, Field(gt=0)] = None
past_present_share_buffer: int = True
repetition_penalty: Annotated[float | None, Field(ge=0.0, le=1.0)] = None
repetition_penalty: Annotated[float | None, Field(gt=0.0)] = None
temperature: Annotated[float | None, Field(ge=0.0, le=2.0)] = None
top_k: Annotated[int | None, Field(gt=0)] = None
top_p: Annotated[float | None, Field(ge=0.0, le=1.0)] = None
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,25 @@ def test_create_options_with_wrong_parameter():
"max_length": 128,
},
)


@pytest.mark.parametrize("repetition_penalty", [0.5, 1.0, 1.1, 1.5, 2.0])
def test_repetition_penalty_accepts_positive_values(repetition_penalty: float):
# onnxruntime-genai: 1.0 means no penalty, values above 1.0 penalize repeated tokens.
settings = OnnxGenAIPromptExecutionSettings(repetition_penalty=repetition_penalty)
assert settings.prepare_settings_dict()["repetition_penalty"] == repetition_penalty


@pytest.mark.parametrize("repetition_penalty", [0.0, -1.0])
def test_repetition_penalty_rejects_non_positive_values(repetition_penalty: float):
# The penalty divides positive logits, so it must be greater than 0.
with pytest.raises(ValidationError):
OnnxGenAIPromptExecutionSettings(repetition_penalty=repetition_penalty)


@pytest.mark.parametrize("length_penalty", [-1.0, -0.5, 0.0, 1.0, 1.5, 2.0])
def test_length_penalty_accepts_values_outside_zero_one(length_penalty: float):
# onnxruntime-genai uses length_penalty as an exponent in beam search: > 0.0 promotes longer
# sequences, < 0.0 promotes shorter ones.
settings = OnnxGenAIPromptExecutionSettings(length_penalty=length_penalty)
assert settings.prepare_settings_dict()["length_penalty"] == length_penalty
Loading