Skip to content

Escape the dot in the .NET detection regex used to label issues - #14446

Open
Kumaresan-AI-Engineer wants to merge 1 commit into
microsoft:mainfrom
Kumaresan-AI-Engineer:ci-issue-label-dotnet-regex
Open

Kumaresan-AI-Engineer wants to merge 1 commit into
microsoft:mainfrom
Kumaresan-AI-Engineer:ci-issue-label-dotnet-regex

Conversation

@Kumaresan-AI-Engineer

Copy link
Copy Markdown

The issue labeler tested bodies and titles with /.net/i. The unescaped dot is a regex wildcard, so any character followed by "net" matched: "internet", "network", "AF_INET", "Mainnet". Python-only issues were labeled .NET as a result, and the label title prefix workflow then rewrote their titles with a ".Net:" prefix.

Escaping the dot makes the check match a literal ".net" (".NET", "ASP.NET"), which is what the comment above it describes. The "dotnet", "C#" and "csharp" checks are unchanged, so genuine .NET issues that spell it that way are still labeled.

Replaying both regexes over the 98 currently open issues changes the outcome for 6 of them; every change removes a false .NET label and none removes a true one. Examples still carrying the wrong label: #14412 ("internet") and #13974 ("Mainnet").

The issue labeler tested bodies and titles with /.net/i. The unescaped dot is a
regex wildcard, so any character followed by "net" matched: "internet", "network",
"AF_INET", "Mainnet". Python-only issues were labeled .NET as a result, and the
label title prefix workflow then rewrote their titles with a ".Net:" prefix.

Escaping the dot makes the check match a literal ".net" (".NET", "ASP.NET"), which
is what the comment above it describes. The "dotnet", "C#" and "csharp" checks are
unchanged, so genuine .NET issues that spell it that way are still labeled.

Replaying both regexes over the 98 currently open issues changes the outcome for 6
of them; every change removes a false .NET label and none removes a true one.
Examples still carrying the wrong label: microsoft#14412 ("internet") and microsoft#13974 ("Mainnet").

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused change has no unresolved blocking issues.

Pull request overview

Escapes the dot in the .NET detection regex so unrelated terms no longer receive the .NET label.

Changes:

  • Matches literal .net.
  • Preserves existing dotnet, C#, and csharp checks.
File summaries
File Description
.github/workflows/label-issues.yml Corrects .NET detection regex.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants