Python: fix kernel_function decorator mutating shared Annotated metadata dicts - #14442
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Open
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Manohar Paturi (ManoharPaturi) wants to merge 1 commit into
Conversation
…ata dicts
_parse_parameter() called meta.pop("description") on dict metadata used
in typing.Annotated, mutating the user-provided dict. When the same
metadata dict is reused across multiple kernel functions (shared
parameter docs), every function after the first silently lost its
parameter description, and the dict itself was permanently modified.
Use meta.get() instead of meta.pop() and filter the description key out
when applying the remaining metadata keys, so semantics are unchanged
but the caller's dict is left untouched.
Manohar Paturi (ManoharPaturi)
requested a review
from a team
as a code owner
September 13, 2026 16:46
Manohar Paturi (ManoharPaturi)
had a problem deploying
to
github-app-auth
September 13, 2026 16:46 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Manohar Paturi (ManoharPaturi)
had a problem deploying
to
github-app-auth
September 13, 2026 16:46 — with
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14441.
_parse_parameter()now reads the description withget()and copies only known keys into the parameter metadata instead ofpop()-ing from the Annotated dict, so decoration never mutates caller-owned dicts and shared metadata keeps working across functions.2 regression tests (shared-dict reuse keeps descriptions; source dict untouched) fail on main and pass here;
tests/unit/functionsgreen.