Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ onnx = [
# onnxruntime>=1.24.0 dropped Python 3.10 support; retain the last compatible runtime/genai pair for 3.10.
"onnxruntime==1.22.1; python_version == '3.10'",
"onnxruntime>=1.26.0; python_version > '3.10'",
"onnxruntime-genai==0.9.0; python_version == '3.10'",
"onnxruntime-genai==0.15.0; python_version == '3.10'",
Comment on lines 119 to +122

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a version inversion: Python 3.10 (with onnxruntime==1.22.1) would now get onnxruntime-genai 0.15.0, while Python >3.10 (with onnxruntime>=1.26.0) stays on the older 0.14.1 on line 123. The newer genai release almost certainly requires a newer onnxruntime, so this bump likely belongs on line 123 (the Python >3.10 line) rather than here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version inversion: this pins onnxruntime-genai==0.15.0 for Python 3.10 (paired with onnxruntime==1.22.1), while Python >3.10 (paired with onnxruntime>=1.26.0) gets the older onnxruntime-genai==0.14.1 on line 123. This is likely backwards — a newer genai release typically requires a newer onnxruntime. If the goal is to bump genai broadly, line 123 should get 0.15.0 and line 122 should retain a version known-compatible with onnxruntime 1.22.1.

Suggested change
"onnxruntime-genai==0.15.0; python_version == '3.10'",
"onnxruntime-genai==0.9.0; python_version == '3.10'",

"onnxruntime-genai==0.14.1; python_version > '3.10'"
]
oracledb = [
Expand Down
Loading