Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python: Bump onnxruntime-genai from 0.9.0 to 0.15.0 in /python #14255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Python: Bump onnxruntime-genai from 0.9.0 to 0.15.0 in /python #14255
Changes from all commits
2ab65a6File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates a version inversion: Python 3.10 (with onnxruntime==1.22.1) would now get onnxruntime-genai 0.15.0, while Python >3.10 (with onnxruntime>=1.26.0) stays on the older 0.14.1 on line 123. The newer genai release almost certainly requires a newer onnxruntime, so this bump likely belongs on line 123 (the Python >3.10 line) rather than here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version inversion: this pins
onnxruntime-genai==0.15.0for Python 3.10 (paired withonnxruntime==1.22.1), while Python >3.10 (paired withonnxruntime>=1.26.0) gets the olderonnxruntime-genai==0.14.1on line 123. This is likely backwards — a newer genai release typically requires a newer onnxruntime. If the goal is to bump genai broadly, line 123 should get 0.15.0 and line 122 should retain a version known-compatible with onnxruntime 1.22.1.Uh oh!
There was an error while loading. Please reload this page.