.Net: Fix GeminiPromptExecutionSettings.Clone dropping settable properties

[dfedoryshchev]

Motivation and Context

GeminiPromptExecutionSettings.Clone() rebuilds the settings through an object initializer, and four settable, serialized properties are missing from it. The clone therefore silently loses function calling, the service identifier, the request labels and the explicit-cache reference.

Function calling is the one that bites hardest. Kernel.CreateFunctionFromPrompt(...) stores a frozen Clone() of the settings it is given (dotnet/src/SemanticKernel.Abstractions/Functions/KernelFunction.cs:176). At request time GeminiPromptExecutionSettings.FromExecutionSettings derives ToolCallBehavior from FunctionChoiceBehavior, and GeminiChatCompletionClient configures the request from ToolCallBehavior. If FunctionChoiceBehavior did not survive the clone, no tools are sent and the model just answers in prose, with no error to explain it.

The four dropped properties:

• ServiceId - [JsonPropertyName("service_id")], dotnet/src/SemanticKernel.Abstractions/AI/PromptExecutionSettings.cs:39
• FunctionChoiceBehavior - [JsonPropertyName("function_choice_behavior")], dotnet/src/SemanticKernel.Abstractions/AI/PromptExecutionSettings.cs:91
• Labels - [JsonPropertyName("labels")], dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs:153
• CachedContent - [JsonPropertyName("cached_content")], dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs:272

The first two are base-class properties that PromptExecutionSettings.Clone() itself copies (PromptExecutionSettings.cs:153-154), and that OllamaPromptExecutionSettings.Clone() copies as well (OllamaPromptExecutionSettings.cs:180 and :187), so the Gemini override loses them rather than deliberately omitting them.

Description

• Copy ServiceId and FunctionChoiceBehavior in Clone(), matching the base implementation.
• Copy CachedContent, and Labels as a new dictionary (matching how ExtensionData and StopSequences are cloned so the clone does not share the caller's instance).
• Extend PromptExecutionSettingsCloneWorksAsExpected so the source settings populate all four properties and the test asserts each one survives the clone.

Every other settable serialized property on GeminiPromptExecutionSettings and its base is now copied.

Contribution Checklist

• The code builds clean without any errors or warnings
• The PR follows the SK Contribution Guidelines
• The existing tests pass
• New tests added

[Copilot]

Pull request overview

This PR fixes a correctness issue in the .NET Google Gemini connector where GeminiPromptExecutionSettings.Clone() previously dropped two serialized, user-settable properties (Labels and CachedContent), causing cloned settings to lose request metadata and explicit caching references.

Changes:

• Update GeminiPromptExecutionSettings.Clone() to clone Labels (as a new dictionary) and copy CachedContent.
• Extend PromptExecutionSettingsCloneWorksAsExpected unit test to set and assert both labels and cached_content survive cloning.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs	Ensures Clone() preserves Labels and CachedContent (previously omitted).
dotnet/src/Connectors/Connectors.Google.UnitTests/GeminiPromptExecutionSettingsTests.cs	Adds assertions verifying the new clone behavior for Labels and CachedContent.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Automated Code Review

Reviewers: 5 | Confidence: 95% | Result: All clear

Reviewed: Correctness, Security Reliability, Test Coverage, Failure Modes, Design Approach

---

Automated review by dfedoryshchev's agents

[dfedoryshchev]

@microsoft-github-policy-service agree