Python: fix GoogleAIChatCompletion requiring api_key when use_vertexai is True#13641
Open
MaxwellCalkin wants to merge 1 commit intomicrosoft:mainfrom
Open
Python: fix GoogleAIChatCompletion requiring api_key when use_vertexai is True#13641MaxwellCalkin wants to merge 1 commit intomicrosoft:mainfrom
MaxwellCalkin wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
ServiceInitializationError: The API key is required when use_vertexai is Falsebeing raised even whenuse_vertexai=True.Fixes #13483.
Problem
In
GoogleAIChatCompletion.__init__, the api_key check on line 122 runs unconditionally:When
use_vertexai=True, authentication is via ADC (Application Default Credentials), not an API key. The api_key should not be required.Fix
Guard the api_key check with
not google_ai_settings.use_vertexai:This is consistent with the error message itself ("when use_vertexai is False") and with
_inner_get_chat_message_contentswhich does not useapi_keywhen Vertex AI is enabled.