Skip to content

Python: Fix Python project metadata #13336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Python: Fix Python project metadata #13336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ dependencies = [
"jinja2 ~= 3.1",
"nest-asyncio ~= 1.6",
"scipy>=1.15.1",
"websockets >= 13, < 16",
"aiortc>=1.9.0",
Copy link
Member

@eavanvalkenburg eavanvalkenburg Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?

Copy link
Author

@Viicos Viicos Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my PR description:

Remove duplicate dependencies

Copy link
Member

@eavanvalkenburg eavanvalkenburg Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they're not actually duplicate, they were first put into the realtime extra, but then we did need them installed as standard, and removing the realtime extra would be a breaking change, so we didn't want to do that. Did now remove the specifiers so we don't get mismatches in them

Copy link
Author

@Viicos Viicos Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is that they are actually duplicates in the dependencies table:

semantic-kernel/python/pyproject.toml

Lines 25 to 55 in 2534964

dependencies = [
# azure agents
"azure-ai-projects >= 1.0.0b12",
"azure-ai-agents >= 1.2.0b3",
"aiohttp ~= 3.8",
"cloudevents ~=1.0",
"pydantic >=2.0,!=2.10.0,!=2.10.1,!=2.10.2,!=2.10.3,<2.12",
"pydantic-settings ~= 2.0",
"defusedxml ~= 0.7",
# azure identity
"azure-identity >= 1.13",
# embeddings
"numpy >= 1.25.0; python_version < '3.12'",
"numpy >= 1.26.0; python_version >= '3.12'",
# openai connector
"openai >= 1.98.0,<2",
# openapi and swagger
"openapi_core >= 0.18,<0.20",
"websockets >= 13, < 16",
"aiortc>=1.9.0",
# OpenTelemetry
"opentelemetry-api ~= 1.24",
"opentelemetry-sdk ~= 1.24",
"prance >= 23.6.21,< 25.4.9",
# templating
"pybars4 ~= 0.9",
"jinja2 ~= 3.1",
"nest-asyncio ~= 1.6",
"scipy>=1.15.1",
"websockets >= 13, < 16",
"aiortc>=1.9.0",

# Protobuf
"protobuf",
# explicit typing extensions
Expand Down Expand Up @@ -157,9 +155,8 @@ weaviate = [
"weaviate-client>=4.17.0,<5.0",
]

[tool.uv]
prerelease = "if-necessary-or-explicit"
dev-dependencies = [
[dependency-groups]
dev = [
"pre-commit ~= 3.7",
"ipykernel ~= 6.29",
"nbconvert ~= 7.16",
Expand All @@ -173,11 +170,15 @@ dev-dependencies = [
"types-PyYAML ~= 6.0.12.20240311",
"ruff ~= 0.9"
]

[tool.uv]
prerelease = "if-necessary-or-explicit"
environments = [
"sys_platform == 'darwin'",
"sys_platform == 'linux'",
"sys_platform == 'win32'"
]
required-version = ">=0.8.4"

[tool.pytest.ini_options]
testpaths = 'tests'
Expand Down
Loading
Loading