Add 'rush-pnpm up' support for catalogs #5585
Open
+512
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benkeen
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #5578
What this is about: right now, when you update packages in a Rush/pnpm repo using
rush-pnpm up, it updates the catalog entries incommon/temp/pnpm-workspace.yaml, but doesn't update Rush's actual catalog, stored inpnpm-config.json, so the update command doesn't fully work. This PR enhances it to update the pnpm-config file too.I also updated it to fix a small issue where JsonFile.save could throw an error due to an
undefined$schema property.Besides the tests, I've ran manual checks with our own Rush repo to confirm the catalog is getting updated properly.