fix(react-native-host): rename inner strongSelf to fix -Wshadow#4143
Open
Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(react-native-host): rename inner strongSelf to fix -Wshadow#4143Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Saadnajmi wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The inner block in -setBridge: redeclares strongSelf, shadowing the outer strongSelf captured for the RCTExecuteOnMainQueue scope. With -Wshadow on this is a -Werror. Rename the inner reference to innerStrongSelf so it no longer shadows the outer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inner block in -setBridge: redeclares strongSelf, shadowing the outer strongSelf captured for the RCTExecuteOnMainQueue scope. With -Wshadow on this is a -Werror.
Rename the inner reference to innerStrongSelf so it no longer shadows the outer.
Description
The inner block in -setBridge: redeclares strongSelf, shadowing the outer strongSelf captured for the RCTExecuteOnMainQueue scope. With -Wshadow on this is a -Werror.
Rename the inner reference to innerStrongSelf so it no longer shadows the outer.
Test plan
Tested internally, where we use stricter xcconfigs.