Skip to content

fix: remove conflicting default=True from store_true CLI flags #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove conflicting default=True from store_true CLI flags #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion batch_infer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def main():
parser.add_argument("--num_workers", type=int, default=0, help="Number of workers for data loading")
parser.add_argument("--output_dir", type=str, default=None,
Copy link
Copy Markdown

@xuanduong2329-source xuanduong2329-source Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True

help="Output directory for rendered images (default: same as input folder)")
parser.add_argument("--save_video", action='store_true', default=True, help="Merge rendered images into a video at video.mp4.")
parser.add_argument("--save_video", action='store_true', help="Merge rendered images into a video at video.mp4.")
parser.add_argument("--tone_mapper", type=str, choices=['none', 'agx', 'filmic', 'pbr_neutral'], default='none', help="Tone mapper for inference")
args = parser.parse_args()

Expand Down
4 changes: 2 additions & 2 deletions scene_processor/to_blend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ def render_scene(camera_config: CameraConfig, output_image_path: str, output_obj
parser.add_argument('--mesh_path', type=str,
help='Path to mesh file. If not provided, a temporary directory will be used',
default=None)
Copy link
Copy Markdown

@xuanduong2329-source xuanduong2329-source Apr 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #12

parser.add_argument('--dump_blend', default=True, action='store_true', help='Save Blender file after rendering')
parser.add_argument('--save_img', default=False, action='store_true', help='Save rendered images')
parser.add_argument('--dump_blend', action='store_true', help='Save Blender file after rendering')
parser.add_argument('--save_img', action='store_true', help='Save rendered images')
parser.add_argument('--resolution', type=int, default=512, help='Resolution of the rendered images')
parser.add_argument('--spp', type=int, default=4096, help='Samples per pixel')

Expand Down