[DRAFT] Circular dependency check

.ado/jobs/cli-init-windows.yml

@@ -39,19 +39,19 @@ parameters:
             template: cpp-lib
             configuration: Release
             platform: x64
-            additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599
+            additionalRunArguments:
             useNuGet: true
           - Name: FabricLibX86Debug
             template: cpp-lib
             configuration: Debug
             platform: x86
-            additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599
+            additionalRunArguments:
             useNuGet: true
           - Name: FabricLibArm64Release
             template: cpp-lib
             configuration: Release
             platform: ARM64
-            additionalRunArguments: --no-deploy --singleproc # --singleproc required to workaround issue #13599
+            additionalRunArguments: --no-deploy
             useNuGet: true
       - BuildEnvironment: SecurePullRequest
         Matrix:
@@ -107,37 +107,37 @@ parameters:
             template: cpp-lib
             configuration: Debug
             platform: x64
-            additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599
+            additionalRunArguments:
             useNuGet: true
           - Name: FabricLibX64Release
             template: cpp-lib
             configuration: Release
             platform: x64
-            additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599
+            additionalRunArguments:
             useNuGet: true
           - Name: FabricLibX86Debug
             template: cpp-lib
             configuration: Debug
             platform: x86
-            additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599
+            additionalRunArguments:
             useNuGet: true
           - Name: FabricLibX86Release
             template: cpp-lib
             configuration: Release
             platform: x86
-            additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599
+            additionalRunArguments:
             useNuGet: true
           - Name: FabricLibArm64Debug
             template: cpp-lib
             configuration: Debug
             platform: ARM64
-            additionalRunArguments: --no-deploy --singleproc # --singleproc required to workaround issue #13599
+            additionalRunArguments: --no-deploy
             useNuGet: true
           - Name: FabricLibArm64Release
             template: cpp-lib
             configuration: Release
             platform: ARM64
-            additionalRunArguments: --no-deploy --singleproc # --singleproc required to workaround issue #13599
+            additionalRunArguments: --no-deploy
             useNuGet: true
 jobs:
   - ${{ each config in parameters.buildMatrix }}:

.ado/jobs/playground.yml

@@ -110,8 +110,6 @@ jobs:
                   msbuildArgs:
                     /p:PackageCertificateKeyFile=$(Build.SourcesDirectory)\EncodedKey.pfx
                     /p:PackageCertificatePassword=${{ parameters.certificatePassword }}
-                ${{if eq(matrix.SolutionFile, 'Playground-Composition.sln')}}:
-                  parallelBuild: false # required to workaround issue #13599
 
             - ${{if and(false, endsWith(matrix.Name, 'Universal'), eq(matrix.BuildConfiguration, 'Debug')) }}: # Disabled as debugging doesn't work,remove false after issue is resolved, see https://github.com/microsoft/react-native-windows/issues/13543
               # Execute debug feature tests (skip this step for the Win32 Playground app and for release builds)

change/react-native-windows-11d17e38-1d0e-4ba7-b807-02f7bf4e0da9.json

@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Try fixing the circular dependency error",
+  "packageName": "react-native-windows",
+  "email": "66076509+vineethkuttan@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}

packages/playground/windows/playground-composition/Playground-Composition.vcxproj

@@ -82,7 +82,7 @@
       <PrecompiledHeaderOutputFile>$(IntDir)pch.pch</PrecompiledHeaderOutputFile>
       <WarningLevel>Level4</WarningLevel>
       <SDLCheck>true</SDLCheck>
-      <AdditionalOptions>%(AdditionalOptions) /bigobj</AdditionalOptions>
+      <AdditionalOptions>%(AdditionalOptions) /bigobj /FS</AdditionalOptions>
       <DisableSpecificWarnings>4453;28204</DisableSpecificWarnings>
     </ClCompile>
     <Link>

vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppLib.props

@@ -13,6 +13,16 @@
     <Warning Text="Property `RnwSdkDefaultsSet` was not set. Please ensure your project imports 'Microsoft.ReactNative.WindowsSdk.Default.props' before importing this prop sheet." />
   </Target>
 
+  <!--
+    Lib/module projects generate Windows Metadata. Explicitly set this to
+    prevent the CppWinRT NuGet target CppWinRTComputeGetResolvedWinMD from
+    trying to compute it, which can cause MSB4006 circular dependency errors
+    during parallel builds (see https://github.com/microsoft/cppwinrt/issues/950).
+  -->
+  <PropertyGroup Label="CppWinRT">
+    <CppWinRTGenerateWindowsMetadata Condition="'$(CppWinRTGenerateWindowsMetadata)' == ''">true</CppWinRTGenerateWindowsMetadata>
+  </PropertyGroup>
+
   <!-- Import common props sheets common to all Composition projects. -->
   <Import Project="$(MSBuildThisFileDirectory)Microsoft.ReactNative.Composition.Common.props" />
 

vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppLib.props

@@ -14,6 +14,16 @@
     <Warning Text="Property `RnwSdkDefaultsSet` was not set. Please ensure your project imports 'Microsoft.ReactNative.WindowsSdk.Default.props' before importing this prop sheet." />
   </Target>
 
+  <!--
+    Lib/module projects generate Windows Metadata. Explicitly set this to
+    prevent the CppWinRT NuGet target CppWinRTComputeGetResolvedWinMD from
+    trying to compute it, which can cause MSB4006 circular dependency errors
+    during parallel builds (see https://github.com/microsoft/cppwinrt/issues/950).
+  -->
+  <PropertyGroup Label="CppWinRT">
+    <CppWinRTGenerateWindowsMetadata Condition="'$(CppWinRTGenerateWindowsMetadata)' == ''">true</CppWinRTGenerateWindowsMetadata>
+  </PropertyGroup>
+
   <!-- Import common props sheets common to all UWP projects. -->
   <Import Project="$(MSBuildThisFileDirectory)Microsoft.ReactNative.Uwp.Common.props" />
 

vnext/templates/cpp-app/windows/MyApp/MyApp.vcxproj

@@ -4,6 +4,8 @@
   <Import Project="$(SolutionDir)\ExperimentalFeatures.props" Condition="Exists('$(SolutionDir)\ExperimentalFeatures.props')" />
   <PropertyGroup Label="Globals">
     <CppWinRTOptimized>true</CppWinRTOptimized>
+    <!-- Prevent MSB4006 circular dependency in CppWinRT during parallel builds (https://github.com/microsoft/cppwinrt/issues/950) -->
+    <CppWinRTGenerateWindowsMetadata>false</CppWinRTGenerateWindowsMetadata>
     <MinimalCoreWin>true</MinimalCoreWin>
     <ProjectGuid>{{ projectGuidUpper }}</ProjectGuid>
     <ProjectName>{{ name }}</ProjectName>