Skip to content

[0.81] Stop writing codegen files if it just changes new lines #15732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoates-ms merged 3 commits into from
Mar 6, 2026
+34 −27
Merged

[0.81] Stop writing codegen files if it just changes new lines #15732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c130fca
Bump TypeScript target to ES2021 (#15727)
acoates-ms Mar 5, 2026
1f2a706
Stop writing codegen files if it just changes new lines (#15729)
acoates-ms Mar 6, 2026
e6fee66
fix change files
acoates-ms Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@react-native-windows-cli-68487113-c891-4125-957b-630701ebe5e8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Bump TS target",
"packageName": "@react-native-windows/cli",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-codegen-e4cfdc4a-a4b9-4a36-8902-cc9aa78db21c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Stop writing codegen files if it just changes new lines",
"packageName": "@react-native-windows/codegen",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@react-native-windows-telemetry-1255120d-5e7d-4c49-a035-b0b9043f6d5a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Bump TS target",
"packageName": "@react-native-windows/telemetry",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
4 changes: 2 additions & 2 deletions change/react-native-windows-8d24c2d8-08f9-4612-a46d-8bf25b0f020d.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "prerelease",
"type": "patch",
"comment": "Implement overflow property support for Fabric architecture",
"packageName": "react-native-windows",
"email": "nitchaudhary@microsoft.com",
"dependentChangeType": "patch"
}
}
4 changes: 2 additions & 2 deletions change/react-native-windows-98ecf15d-5d4a-4fd9-8197-192eaf831e5f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "prerelease",
"type": "patch",
"comment": "Fix SHIFT+F10 keyboard shortcut for context menu in TextInput",
"packageName": "react-native-windows",
"email": "nitchaudhary@microsoft.com",
"dependentChangeType": "patch"
}
}
4 changes: 2 additions & 2 deletions change/react-native-windows-b56ee389-667d-4a9b-bc6a-73fa937f57c8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "prerelease",
"type": "patch",
"comment": "Fix TextInput selection crash and feedback loop",
"packageName": "react-native-windows",
"email": "74712637+iamAbhi-916@users.noreply.github.com",
"dependentChangeType": "patch"
}
}
4 changes: 2 additions & 2 deletions change/react-native-windows-facaf084-1207-4661-8ca0-5613b6ed5129.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"type": "prerelease",
"type": "patch",
"comment": "Implement ReactNativeWindow",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
}
8 changes: 0 additions & 8 deletions packages/@react-native-windows/cli/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
{
"extends": "@rnw-scripts/ts-config",
"compilerOptions": {
// Change the default to allow ES2019.String "trimEnd"
"lib": [
"DOM",
"ES6",
"DOM.Iterable",
"ES2019.String"
],

// Not clean
"strictFunctionTypes": false,
},
Expand Down
6 changes: 4 additions & 2 deletions packages/@react-native-windows/codegen/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@ function checkFilesForChanges(
}

const currentContents = fs.readFileSync(fileName, 'utf8');
if (currentContents !== contents) {
// The current file may be saved using crlf, in which case the new lines may differ from the new output
if (currentContents.replaceAll('\r\n', '\n') !== contents) {
console.log(`- ${fileName} has changed`);
hasChanges = true;
continue;
Expand Down Expand Up @@ -146,7 +147,8 @@ function writeMapToFiles(map: Map<string, string>, outputDir: string) {
if (fs.existsSync(fileName)) {
const currentContents = fs.readFileSync(fileName, 'utf8');
// Don't update the files if there are no changes as this breaks incremental builds
if (currentContents === contents) {
// The current file may be saved using crlf, in which case the new lines may differ from the new output
if (currentContents.replaceAll('\r\n', '\n') === contents) {
continue;
}
}
Expand Down
8 changes: 0 additions & 8 deletions packages/@react-native-windows/telemetry/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
{
"extends": "@rnw-scripts/ts-config",
"compilerOptions": {
// Change the default to allow ES2019.String "trimEnd"
"lib": [
"DOM",
"ES6",
"DOM.Iterable",
"ES2019.String"
],

// Not clean
"strictFunctionTypes": false,
"isolatedModules": false,
Expand Down
2 changes: 1 addition & 1 deletion packages/@rnw-scripts/ts-config/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "ES2018",
"target": "ES2021",
"module": "commonjs",
"jsx": "react",
"sourceMap": true,
Expand Down
Loading