Migrate to jupyterlab 4.6 - #3676
Open
Dima Fedoriaka (fedimser) wants to merge 2 commits into
Open
Conversation
Dima Fedoriaka (fedimser)
marked this pull request as ready for review
September 3, 2026 18:32
Dima Fedoriaka (fedimser)
requested review from
Andrew Casey (amcasey),
Bill Ticehurst (billti) and
Ian Davis (idavis)
as code owners
September 3, 2026 18:32
Copilot started reviewing on behalf of
Dima Fedoriaka (fedimser)
September 8, 2026 19:54
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated dev build script passes --development True, which is incompatible with jupyter-builder’s boolean flag semantics and will likely break npm run build:labextension:dev.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the Q# JupyterLab extension packaging/build configuration to target JupyterLab 4.6 and migrate the frontend build pipeline to jupyter-builder/@jupyter/builder per the upstream migration guidance, primarily to address Dependabot/security-driven upgrade pressure.
Changes:
- Bumps JupyterLab JS dependencies from
^4.5.10to^4.6.0. - Switches the labextension build scripts from
@jupyterlab/buildertojupyter-builderand addsjupyter-builderto the Python build-system requirements. - Regenerates
package-lock.jsonfor the new dependency graph and updates build docs accordingly.
File summaries
| File | Description |
|---|---|
| source/jupyterlab/pyproject.toml | Adds jupyter-builder to the PEP 517 build requirements used when building the Python package/wheel. |
| source/jupyterlab/package.json | Updates build scripts to use jupyter-builder and upgrades JupyterLab deps to 4.6; replaces builder devDependency. |
| source/jupyterlab/package-lock.json | Updates lockfile to reflect the new builder package and JupyterLab 4.6 dependency tree. |
| source/jupyterlab/jupyterlab-core/package.json | Updates the pinned “core” package.json version used for the builder core reference. |
| source/jupyterlab/BUILDING.md | Updates local build instructions to include installing jupyter-builder. |
Review details
Files not reviewed (1)
- source/jupyterlab/package-lock.json: Generated file
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "build:lib": "node ../../node_modules/typescript/bin/tsc -p ./tsconfig.json", | ||
| "build:labextension:dev": "node node_modules/@jupyterlab/builder/lib/build-labextension.js --core-path ./jupyterlab-core --development .", | ||
| "build:labextension:prod": "node node_modules/@jupyterlab/builder/lib/build-labextension.js --core-path ./jupyterlab-core ." | ||
| "build:labextension:dev": "jupyter-builder build --core-package-file ./jupyterlab-core/package.json --development True .", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jupyter-builderpackagenpm install --package-lock-only --prefix source/jupyterlabFixes #3563