Ensure that extension card button and links work with screen reader#11284
Open
microbit-robert wants to merge 2 commits intomicrosoft:masterfrom
Open
Ensure that extension card button and links work with screen reader#11284microbit-robert wants to merge 2 commits intomicrosoft:masterfrom
microbit-robert wants to merge 2 commits intomicrosoft:masterfrom
Conversation
Placeholder image icons and loading spinners sit above the button without bumping the z-index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pressing Enter or Space on the "learn more" link of an extension card while running NVDA, the card itself as a button is triggered. This adds the extension to the project and makes it impossible for screen reader users to navigate to the extension documentation.
The theme card has been tweaked slightly in response to the card change to maintain current screen reader behaviour.
This PR restructures the card so that both the button and link can be triggered independently. No changes for mouse users or keyboard users without a screen reader are expected.