fix(highlight): prevent page ::backdrop styles from tinting screenshots#41505
Open
aydinomer00 wants to merge 1 commit into
Open
fix(highlight): prevent page ::backdrop styles from tinting screenshots#41505aydinomer00 wants to merge 1 commit into
aydinomer00 wants to merge 1 commit into
Conversation
The glass pane is promoted to the top layer via the popover API, which renders a ::backdrop pseudo-element. That pseudo-element lives in the light DOM and is styled by page stylesheets, so page rules targeting ::backdrop bled onto it and tinted screenshots, including masked screenshots. Neutralize the glass pane backdrop from a document-level stylesheet. Fixes microsoft#41504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::backdroppseudo-element styled by page stylesheets. Page rules targeting::backdropleaked onto it and tinted screenshots, including masked screenshots (regression since 1.59).::backdropfrom a document-level stylesheet.Fixes #41504