chore: remove unused env var flags (PLAYWRIGHT_LEGACY_SCREENSHOT, PW_CODEGEN_NO_INSPECTOR, PW_DETECT_NESTED_PROGRESS)#41500
Open
faisalaffan wants to merge 1 commit into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
faisalaffan
changed the title
chore: remove unused env var flags (PLAYWRIGHT_LEGACY_SCREENSHOT, PW_CODEGEN_NO_INSPECTOR, PW_DETECT_NESTED_PROGRESS)
…CODEGEN_NO_INSPECTOR, PW_DETECT_NESTED_PROGRESS)
faisalaffan
force-pushed
the
chore-dead-env-vars
branch
from
bac49c5 to
21f3e7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 3 env var flags that are never set anywhere in the repo, docs, or configs.
PLAYWRIGHT_LEGACY_SCREENSHOT— ternary defaulting to CDP flag;''branch never executesPW_CODEGEN_NO_INSPECTOR— two early-return guards in recorder; dead since Jul 2025 refactorPW_DETECT_NESTED_PROGRESS— debug-only nested race detection block + cascading dead vars (outerProgress,allowConcurrent,setAllowConcurrentOrNestedRaces)