fix(proxy): ensure the host field is correct when using proxy#40797
Open
Archkon wants to merge 1 commit into
Open
fix(proxy): ensure the host field is correct when using proxy#40797Archkon wants to merge 1 commit into
Archkon wants to merge 1 commit into
Conversation
Archkon
changed the title
Member
|
Please start with opening an issue that describes the problem, so that we can evaluate it. |
yury-s
requested changes
May 13, 2026
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
Looks good, but please add a test for this. See e.g. 'should use env proxy with connectOverCDP discovery request' in tests/library/chromium/connect-over-cdp.spec.ts.
| options.path = url.toString(); | ||
| const headers = options.headers || {}; | ||
| if (!Object.keys(headers).some(header => header.toLowerCase() === 'host')) | ||
| headers.Host = url.host; |
Member
There was a problem hiding this comment.
Suggested change
| headers.Host = url.host; | |
| headers.host = url.host; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host field should be set according target url not the proxy url
refer to https://www.rfc-editor.org/rfc/rfc9112#section-3.2.2