Skip to content

Conversation

@aviavi16
Copy link

@aviavi16 aviavi16 commented Feb 2, 2026

The tests named "should render unexpected" exercise expect() assertion failures (JUnit ),
not unexpected runtime errors ().

Renaming improves clarity and avoids confusion when working on JUnit error vs failure reporting.

@aviavi16
Copy link
Author

aviavi16 commented Feb 2, 2026

Why rename the tests?
This prevents confusion in the context of discussions around JUnit vs (see #12944).
The name “unexpected” suggests a runtime error (), while these tests actually exercise expect() assertion failures ().

Because of that mismatch, it can look like the tests are related to or even “cover” #12944, while in practice they do not.
Renaming makes the intent explicit and avoids misleading conclusions when working on JUnit error/failure reporting.

Regarding the “after retry” test:
That test was renamed as well, so both the base case and the retry scenario are consistently covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant