feat: add support for omitting selectors in generateSelector options#39067
Closed
Shahalt1 wants to merge 1 commit intomicrosoft:mainfrom
Closed
feat: add support for omitting selectors in generateSelector options#39067Shahalt1 wants to merge 1 commit intomicrosoft:mainfrom
Shahalt1 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
- Enhanced the generateSelector function to accept an omitSelectors option, allowing users to specify which selector sources to exclude (e.g., id). - Updated related components to utilize the new omitSelectors option, ensuring consistent behavior across the codebase. - Modified CLI to support --omit-selectors argument for code generation.
Contributor
|
Thank you for the PR! I think this is a too narrow usecase to introduce this command line flag. Not to mention that any other tooling, e.g. VSCode extension, will not work in this case. We'd prefer the issue to be solved differently: by recommending better/multiple selectors to the user, or perhaps some extended options in the UI/api, but not with a targeted command line flag like this one. If you'd like to contribute, please tackle #5178 instead. Again, thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue : #39066