Skip to content

feat(mcp cli): add barebones "test" command#39032

Closed
dgozman wants to merge 1 commit intomicrosoft:mainfrom
dgozman:feat-mcp-cli-test
Closed

feat(mcp cli): add barebones "test" command#39032
dgozman wants to merge 1 commit intomicrosoft:mainfrom
dgozman:feat-mcp-cli-test

Conversation

@dgozman
Copy link
Contributor

@dgozman dgozman commented Jan 29, 2026

No description provided.

@github-actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › expect-configure.spec.ts:38 › should configure message @macos-latest-node20

8 flaky ⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@ubuntu-22.04-chromium-tip-of-tree`
⚠️ [chromium-library] › library/inspector/recorder-api.spec.ts:120 › should type `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/popup.spec.ts:258 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/browsercontext-add-cookies.spec.ts:426 › should allow unnamed cookies `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:185 › should show snapshots for steps `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:700 › should indicate current test status `@macos-latest-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:812 › should update state on subsequent run `@macos-latest-node20`

34237 passed, 663 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

13 failed
❌ [chrome] › mcp/cli.spec.ts:599 › versions › old daemon @mcp-ubuntu-latest
❌ [firefox] › mcp/cli.spec.ts:44 › core › close @mcp-ubuntu-latest
❌ [chrome] › mcp/cli.spec.ts:284 › save as › screenshot @mcp-macos-15
❌ [chrome] › mcp/cli.spec.ts:387 › devtools › video-start-stop @mcp-macos-15
❌ [chrome] › mcp/cli.spec.ts:511 › session › session-delete non-existent session @mcp-macos-15
❌ [chrome] › mcp/core.spec.ts:158 › browser_resize @mcp-macos-15
❌ [chrome] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15
❌ [chrome] › mcp/test-debug.spec.ts:234 › test_debug / evaluate x 2 @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:292 › save as › screenshot --full-page @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:387 › devtools › video-start-stop @mcp-macos-15
❌ [chromium] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15
❌ [webkit] › mcp/cli.spec.ts:28 › help › prints command help @mcp-macos-15
❌ [webkit] › mcp/cli.spec.ts:468 › session › session-stop non-running session @mcp-macos-15

3615 passed, 129 skipped


Merge workflow run.

{
let playwrightTestDir;
try {
playwrightTestDir = path.resolve(require.resolve('@playwright/test', { paths: [process.cwd()] }), '..');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we go off playwright that we already depend on?

private _resolveSessionName(sessionName?: string): string {
if (sessionName)
private async _resolveSessionName(sessionName: string | undefined, test: 'force-test' | 'prefer-test' | 'disallow-test'): Promise<string> {
sessionName = sessionName ?? process.env.PLAYWRIGHT_CLI_SESSION;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not liking it honestly, session name should be solid.

@dgozman dgozman closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants