Skip to content

chore(ui): open UI on --port=0 by default for coding agents#38981

Closed
Skn0tt wants to merge 7 commits intomicrosoft:mainfrom
Skn0tt:trace-viewer-open-with-cli
Closed

chore(ui): open UI on --port=0 by default for coding agents#38981
Skn0tt wants to merge 7 commits intomicrosoft:mainfrom
Skn0tt:trace-viewer-open-with-cli

Conversation

@Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jan 27, 2026

Coding agents like opening ports with playwright-cli, so let's give them --port=0 by default. Also fixes a bug where show-trace --port=0 printed Listening on https://undefined:1234, and removes an unused fixture from our test suite. See #38936.

@Skn0tt Skn0tt requested a review from dgozman January 27, 2026 09:24
@Skn0tt Skn0tt self-assigned this Jan 27, 2026
@Skn0tt Skn0tt changed the title chore(ui): remove coding agent papercuts chore(ui): open UI on --port=0 by default for coding agents Jan 27, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Skn0tt Skn0tt force-pushed the trace-viewer-open-with-cli branch from 4616fc1 to c4681dd Compare January 27, 2026 10:53
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

}

export function isCodingAgent(): boolean {
return !!process.env.CLAUDECODE;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks vendor-locked.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

}

// https://github.com/firebase/firebase-tools/blob/fbaa1af6fd7a6b1bdb8c21ace7d3ec4f0959c989/src/env.ts#L16C1-L25C2
export function isCodingAgent() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see copilot here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither Copilot CLI nor Copilot in VS Code expose any identifying markers currently, sadly :/

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Skn0tt Skn0tt requested a review from dgozman February 3, 2026 12:31
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Test results for "tests 1"

4 flaky ⚠️ [chromium-page] › page/page-event-console.spec.ts:250 › should have timestamp in consoleMessages `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-event-console.spec.ts:250 › should have timestamp in consoleMessages `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:700 › should indicate current test status `@macos-latest-node20`

34231 passed, 756 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Test results for "MCP"

3 failed
❌ [firefox] › mcp/test-debug.spec.ts:21 › test_debug (passed) @mcp-windows-latest
❌ [firefox] › mcp/test-debug.spec.ts:48 › test_debug (pause/resume) @mcp-windows-latest
❌ [chromium] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15

4685 passed, 135 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments