Skip to content

Stop lowercasing module file names sometimes#2419

Open
Mattwmaster58 wants to merge 1 commit into
microsoft:mainfrom
Mattwmaster58:no-lowercase
Open

Stop lowercasing module file names sometimes#2419
Mattwmaster58 wants to merge 1 commit into
microsoft:mainfrom
Mattwmaster58:no-lowercase

Conversation

@Mattwmaster58
Copy link
Copy Markdown

This is a suggestion for how to fix dotnet/diagnostics#5835.

I don't understand the codebase in depth so I'm really not sure this is the correct fix. But what I do know is that speedscope casing is now consistent. Empirically, it looks like this constructor where the module name is lowercases is used some portion of the time, and then other times the correctly case module name is used via some other codepath. But that's just a guess.

Here's a random example before. Unfortunately, the speedscope files are too big, so screenshots of speedscope.app is all I can easily provide:

Old behavior. Notably, most of the modules are correctly cased, but not all:
image
image

Behavior with this patch (modules consistently case, speedscope can correctly group calls together, color consistently, etc)

image image

@Mattwmaster58 Mattwmaster58 requested a review from a team as a code owner May 8, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotnet-trace speedscope format does not case normalize correctly

2 participants