Stop lowercasing module file names sometimes#2419
Open
Mattwmaster58 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a suggestion for how to fix dotnet/diagnostics#5835.
I don't understand the codebase in depth so I'm really not sure this is the correct fix. But what I do know is that speedscope casing is now consistent. Empirically, it looks like this constructor where the module name is lowercases is used some portion of the time, and then other times the correctly case module name is used via some other codepath. But that's just a guess.
Here's a random example before. Unfortunately, the speedscope files are too big, so screenshots of speedscope.app is all I can easily provide:
Old behavior. Notably, most of the modules are correctly cased, but not all:


Behavior with this patch (modules consistently case, speedscope can correctly group calls together, color consistently, etc)