Skip to content

Add device code review skill and refresh CI - #862

Open
Binyang Li (Binyang2014) wants to merge 13 commits into
mainfrom
binyli/device-code-review-skill
Open

Add device code review skill and refresh CI#862
Binyang Li (Binyang2014) wants to merge 13 commits into
mainfrom
binyli/device-code-review-skill

Conversation

@Binyang2014

@Binyang2014 Binyang Li (Binyang2014) commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a reusable device-code review skill for CUDA/HIP changes
  • update the development container base image to CUDA 13.0
  • run lint jobs on Ubuntu 24.04
  • remove the CUDA compatibility directory from the mscclpp-lang workflow's LD_LIBRARY_PATH
  • restore the original Azure build path on remote coverage VMs so lcov can read source files
  • tolerate lcov 2.x inconsistent coverage metadata and use accurate summary output
  • disable the ROCm 7.2 code coverage matrix entry
  • skip host-side atomic signaling tests in SM90 and ROCm Debug coverage runs

Testing

  • H100 Debug coverage with the filters: unit tests 4.6 seconds, 2-rank tests 53.2 seconds, 4-rank tests 55.4 seconds
  • verified the filter condition remains disabled for CUDA SM80 and enabled for CUDA SM90 and ROCm
  • A100 coverage continues to exercise the excluded paths
  • ran ./tools/lint.sh

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@Binyang2014
Binyang Li (Binyang2014) requested a review from a team August 6, 2026 21:46
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.53%. Comparing base (be9126c) to head (3ca5207).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
+ Coverage   59.62%   67.53%   +7.91%     
==========================================
  Files          57       61       +4     
  Lines        5278     5844     +566     
==========================================
+ Hits         3147     3947     +800     
+ Misses       2131     1897     -234     
Flag Coverage Δ
cuda-80 62.56% <ø> (+2.32%) ⬆️
cuda-90 67.73% <ø> (?)
rocm-gfx942 60.00% <ø> (-3.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
Dispatch host stores using compile-time memory-order constants so relaxed and release stores do not degrade to locked exchanges in unoptimized builds.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
Keep the public atomic API unchanged and exclude the BAR1 atomic polling and HostNoAtomic cases only from H100 Debug coverage runs. A100 coverage and H100 Release tests continue to exercise these paths.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
Skip the host-side atomic signaling tests in ROCm coverage jobs as well as SM90, while retaining their A100 coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: abcfbf37-b510-4998-a410-486ecf891f3a
Allow the full ROCm coverage test matrix to complete without hitting the previous 40-minute job limit.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: df887bd1-912c-4cbf-9dc1-cbf78eaea7bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant