-
Notifications
You must be signed in to change notification settings - Fork 371
CodeToCloud tool feature parity for Deploy and Quota area #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wchigit
wants to merge
13
commits into
main
Choose a base branch
from
wc/c2c-tool-parity'
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ac8156f
pipeline update
wchigit 131719d
fix pipeline tests
wchigit da1ef6a
plan get update
wchigit 45e47ba
iac rules
wchigit f9c812e
region
wchigit 3a1cde3
quota dep
wchigit 33798f2
quota
wchigit a06c0b9
quota fix
wchigit e924bbe
merge
wchigit 46c9cd2
update prompt
wchigit 5a34c84
whitespaces
wchigit c5998b6
unit test
wchigit e09929a
live test
wchigit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
tools/Azure.Mcp.Tools.Deploy/src/Models/PipelineParameters.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| namespace Azure.Mcp.Tools.Deploy.Models; | ||
|
|
||
| public static class DeployOption | ||
| { | ||
| public const string ProvisionAndDeploy = "provision-and-deploy"; | ||
| public const string DeployOnly = "deploy-only"; | ||
| public const string ProvisionOnly = "provision-only"; | ||
| } | ||
|
|
||
| public static class PipelinePlatform | ||
| { | ||
| public const string GitHubActions = "github-actions"; | ||
| public const string AzureDevOps = "azure-devops"; | ||
| } |
52 changes: 52 additions & 0 deletions
52
tools/Azure.Mcp.Tools.Deploy/src/Models/Templates/CLIExecutionStepsTemplateParameters.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| namespace Azure.Mcp.Tools.Deploy.Models.Templates; | ||
|
|
||
| /// <summary> | ||
| /// Parameters for generating deployment plan templates. | ||
| /// </summary> | ||
| public sealed class CLIExecutionStepsTemplateParameters | ||
| { | ||
| /// <summary> | ||
| /// The azure compute host display name. | ||
| /// </summary> | ||
| public string AzureComputeHost { get; set; } = string.Empty; | ||
|
|
||
| /// <summary> | ||
| /// The azure cli command group title | ||
| /// </summary> | ||
| public string TargetAppCommandTitle { get; set; } = string.Empty; | ||
|
|
||
| /// <summary> | ||
| /// The deployment steps | ||
| /// </summary> | ||
| public string DeploymentSteps { get; set; } = string.Empty; | ||
|
|
||
| /// <summary> | ||
| /// The IaC type | ||
| /// </summary> | ||
| public string IaCType { get; set; } = string.Empty; | ||
|
|
||
| /// <summary> | ||
| /// The step to check ACR dependencies | ||
| /// </summary> | ||
| public string ACRDependencyCheck { get; set; } = string.Empty; | ||
|
|
||
|
|
||
| /// <summary> | ||
| /// Converts the parameters to a dictionary for template processing. | ||
| /// </summary> | ||
| /// <returns>A dictionary with parameter names as keys and their values.</returns> | ||
| public Dictionary<string, string> ToDictionary() | ||
| { | ||
| return new Dictionary<string, string> | ||
| { | ||
| { nameof(IaCType), IaCType }, | ||
| { nameof(AzureComputeHost), AzureComputeHost }, | ||
| { nameof(TargetAppCommandTitle), TargetAppCommandTitle }, | ||
| { nameof(DeploymentSteps), DeploymentSteps }, | ||
| { nameof(ACRDependencyCheck), ACRDependencyCheck } | ||
| }; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
azmcp deploy plan getdocs were only updated to rename--azd-iac-optionsto--iac-options, but the tool now also supports/accepts--source-type,--deploy-option, and--resource-group-name(and subscription viaSubscriptionOptions). Update this command snippet to include the new flags (and indicate which are required vs optional) so the docs match the actual CLI surface.