Skip to content

Fix CI pipeline tests failure #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix CI pipeline tests failure #1090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a4958c
addressed tests bugs
achyuth-ms Nov 6, 2025
8e6001c
revert to validate in CI pipeline
achyuth-ms Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion servers/Azure.Mcp.Server/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ The Azure MCP Server updates automatically by default whenever a new release com

### Bugs Fixed

- Fixed test failures in CI for SQL commands for `BaseSqlCommand` (--server option) and `BaseDatabaseCommand` (--database option) by using `.AsRequired()` extension method for consistent validation. [[#943](https://github.com/microsoft/mcp/issues/943), [#1013](https://github.com/microsoft/mcp/issues/1013)]
Copy link
Member

@joshfree joshfree Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if the changes end up being fixes to the tests themselves, and not to the product, maybe move these to the Other Changes section right below

- Avoid spawning child processes per namespace for consolidated mode [[#1002](https://github.com/microsoft/mcp/pull/1002)]
- Improvement to learning experience by ignoring `command` parameter, which resulted in neither learning nor a tool call to happen. Learning is now always invoked when `learn=true` is passed. [[#1057](https://github.com/microsoft/mcp/pull/1057)]
- Adds descriptions to the tools metadata, to ensure enough information is present in the cli to generate docs for metadata. [[#1043](https://github.com/microsoft/mcp/pull/1043)]
- Adds descriptions to the tools metadata, to ensure enough information is present in the cli to generate docs for metadata. [[#1043](https://github.com/microsoft/mcp/pull/1043)]

### Other Changes

Expand Down
3 changes: 2 additions & 1 deletion tools/Azure.Mcp.Tools.Sql/src/Commands/BaseDatabaseCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Diagnostics.CodeAnalysis;
using Azure.Mcp.Core.Commands;
using Azure.Mcp.Core.Extensions;
using Azure.Mcp.Core.Models.Option;
using Azure.Mcp.Tools.Sql.Options;
using Microsoft.Extensions.Logging;

Expand All @@ -16,7 +17,7 @@ public abstract class BaseDatabaseCommand<
protected override void RegisterOptions(Command command)
{
base.RegisterOptions(command);
command.Options.Add(SqlOptionDefinitions.Database);
command.Options.Add(SqlOptionDefinitions.Database.AsRequired());
}

protected override TOptions BindOptions(ParseResult parseResult)
Expand Down
Loading